-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
s-leroux
commented
Aug 24, 2026
Owner
Thank you for your contribution.
This is a highly seasonal project, and I am not actively working on it right now. I will, however, review your PR in due time.
Regards
-- Sylvain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToCurveChainNameandFromCurveChainNameasRecord<string, string | undefined>__proto__object-literal workaround and@ts-expect-errorcomments with a typed null-prototype map helpergnosis<->xdai)Closes #100.
Verification
npm run compilenodeimport smoke check againstbuild/src/services/curve/curveapi.mjsverified:ToCurveChainName.gnosis === "xdai"FromCurveChainName.xdai === "gnosis"undefinedNotes:
npm test -- --grep CurveAPIcurrently has one unrelated floating-point fixture mismatch (1.0397308967364007vs1.0397308967364005) ingetPrice(); the other CurveAPI checks in that grep pass.npm run lintreports pre-existing project-wide lint errors outside this focused change; no unrelated files are included in this PR.