Skip to content

Navigation Menu

Sign in
Sign up

✅ Add calendar validation to parseDate - #166

Draft
s-leroux wants to merge 1 commit into
main from
codex/address-github-issue-#152
Draft

✅ Add calendar validation to parseDate #166
s-leroux wants to merge 1 commit into
main from
codex/address-github-issue-#152

Conversation

@s-leroux

@s-leroux s-leroux commented Nov 13, 2025

Copy link
Copy Markdown
Owner

Summary

  • add a calendar validity check to parseDate so invalid dates are rejected
  • raise a clear ValueError when the parsed date does not exist
  • extend the unit test suite to cover invalid day and month combinations

Testing

  • time npx tsc --pretty false
  • GNOSISSCAN_API_KEY=dummy COINGECKO_API_KEY=dummy npx mocha 'build/test/date.spec.mjs'

Codex Task

@s-leroux s-leroux added the codex Reserved for the OpenAI Codex AI label Nov 13, 2025 — with ChatGPT Codex Connector
s-leroux marked this pull request as draft November 13, 2025 10:04

Copy link
Copy Markdown
Owner Author

This is typically an example of what the AI can do well:

  • local changes,
  • no complex context to understand,
  • public interface and semantics remain unchanged.

@s-leroux s-leroux changed the title (削除) Add calendar validation to parseDate (削除ここまで) (追記) ✅ Add calendar validation to parseDate (追記ここまで) Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex Reserved for the OpenAI Codex AI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /