Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add discard_errdata() method to Result #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GabrielMajeri merged 2 commits into rust-osdev:master from josephlr:errdata
Jan 25, 2019

Conversation

Copy link
Contributor

@josephlr josephlr commented Jan 25, 2019

Most functions in the uefi package return a Result<Output>, but some return Result<Output, ErrData>. This makes it challenging to write your own methods returning Resut<T>, especially because the Error type is not exported.

An easy way to fix this is to just add a method converting a Result<Output, ErrData> to a Result<Output>, keeping the status but discarding the data.

GabrielMajeri reacted with thumbs up emoji
@GabrielMajeri GabrielMajeri merged commit 2a479cc into rust-osdev:master Jan 25, 2019
@josephlr josephlr deleted the errdata branch January 25, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /