-
-
Notifications
You must be signed in to change notification settings - Fork 178
device_path: add more convenience (part 1) #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
device_path: add more convenience (part 1) #827
Conversation
@blitz Is this something that you think is helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be useful for our internal loader usecase. 👍
016e890 to
da33c00
Compare
59494c5 to
bace1c6
Compare
bace1c6 to
48b7b5d
Compare
b5abddc to
4038e0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path will be different on aarch64, so might want to use an if cfg!(...) here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right! At the first glance, I do not see where this difference comes from. Can you give me a pointer, please? I guess, its the way that xtask prepares the QEMU command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's just due to the edk2 firmware. Although we tend to refer to it as OVMF, OVMF is actually only for ia32/x86_64, while ArmVirtPkg is used on ARM.
bbe32d6 to
60e4979
Compare
60e4979 to
91abef9
Compare
Uh oh!
There was an error while loading. Please reload this page.
This MR adds convenient methods to transform device paths easier to text. This should make it easier for devs to work with device paths (through convenient debug output).
The debug output of my example is sth like this:
for the first helper method (
.to_node_string_pairs)image
for the second helper method (
.to_string)image
Checklist