-
-
Notifications
You must be signed in to change notification settings - Fork 178
Add UTF-8 to UCS-2 encoding and Simple File System Protocol support #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge pull request rust-osdev#6 from FredrikAleksander/master
Thanks for contributing to this project.
It's easier for me to review and keep track of pull requests if they focus on one thing at a time.
You should keep your fork's master branch clean, and work on various features on different branches.
It would be great if you could break this pull request into two different pull requests, corresponding to the two features:
- A new pull request for adding UTF-8 to UCS-2 conversion functions
- Another one for adding filesystem support
And then we will close this one and discuss those ones.
Sure, I'll make one for ucs-2 first then i'll make anotjer one for SFS when ucs-2 is merged (sfs uses the ucs-2 function
Uh oh!
There was an error while loading. Please reload this page.
Simple UTF-8 -> UCS-2 routine. Supports all multibyte UTF-8 sequences that are UCS-2 compatable.
Added most of the Simple File System Protocol, besides GetInfo and SetInfo on EFI_FILE_PROTOCOL. Still new to Rust, so not quite sure how to to provide those idiomatically