-
-
Notifications
You must be signed in to change notification settings - Fork 178
error: enable core::error::Error for all error payloads #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
517eca9 to
af2e3af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good solution to me. Should probably mention in the changelog that Error's Data parameter is no longer required to implement Display.
af2e3af to
7f77fc5
Compare
7f77fc5 to
26717f6
Compare
I've added another commit because I think the current doc comment doesn't reflect the usage
well. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Implements a solution for the discussion in #691.
Checklist