-
-
Notifications
You must be signed in to change notification settings - Fork 180
"is_regular_file" for file trait + integration test #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@phip1611
phip1611
force-pushed
the
is-file-is-directory
branch
2 times, most recently
from
July 31, 2022 15:06
88dbcc1 to
3018cfb
Compare
@phip1611
phip1611
changed the title
(削除) "is_regular_file" for file trait + integration test (削除ここまで)
(追記) "is_regular_file" for file trait and FileHandle::into_type() no longer returns a result + integration test (追記ここまで)
Jul 31, 2022
phip1611
phip1611
commented
Jul 31, 2022
@phip1611
phip1611
force-pushed
the
is-file-is-directory
branch
from
July 31, 2022 15:44
147343c to
2c12656
Compare
phip1611
phip1611
commented
Jul 31, 2022
Short notice: I'm currently on vacation and probably won't work on the PRs until the last week of August
@phip1611
phip1611
force-pushed
the
is-file-is-directory
branch
from
August 27, 2022 12:48
2c12656 to
2bf06d5
Compare
This is ready for the next review round.
@phip1611
phip1611
changed the title
(削除) "is_regular_file" for file trait and FileHandle::into_type() no longer returns a result + integration test (削除ここまで)
(追記) "is_regular_file" for file trait + simple file system protocol integration test (追記ここまで)
Aug 27, 2022
@phip1611
phip1611
force-pushed
the
is-file-is-directory
branch
from
September 1, 2022 13:40
2bf06d5 to
8f009c0
Compare
nicholasbishop
nicholasbishop
requested changes
Sep 1, 2022
@phip1611
phip1611
force-pushed
the
is-file-is-directory
branch
from
September 6, 2022 15:43
8f009c0 to
83ade2e
Compare
@phip1611
phip1611
changed the title
(削除) "is_regular_file" for file trait + simple file system protocol integration test (削除ここまで)
(追記) "is_regular_file" for file trait + integration test (追記ここまで)
Sep 6, 2022
@phip1611
phip1611
changed the title
(削除) "is_regular_file" for file trait + integration test (削除ここまで)
(追記) Draft: "is_regular_file" for file trait + integration test (追記ここまで)
Sep 6, 2022
@phip1611
phip1611
force-pushed
the
is-file-is-directory
branch
2 times, most recently
from
September 6, 2022 17:04
759588f to
e20ba60
Compare
@phip1611
phip1611
changed the title
(削除) Draft: "is_regular_file" for file trait + integration test (削除ここまで)
(追記) "is_regular_file" for file trait + integration test (追記ここまで)
Sep 6, 2022
@phip1611
phip1611
force-pushed
the
is-file-is-directory
branch
from
September 6, 2022 17:06
e20ba60 to
eb2659c
Compare
This is necessary as preparation for the integration test.
@phip1611
phip1611
force-pushed
the
is-file-is-directory
branch
from
September 6, 2022 17:06
eb2659c to
38d7eae
Compare
Ready for another review round @nicholasbishop
@phip1611
phip1611
force-pushed
the
is-file-is-directory
branch
from
September 6, 2022 17:12
38d7eae to
f8bd537
Compare
@phip1611
phip1611
force-pushed
the
is-file-is-directory
branch
from
September 6, 2022 17:13
f8bd537 to
09b01a9
Compare
nicholasbishop
nicholasbishop
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This MR adds the "is_regular_file" and "is_regular_directory"-methods for the File-trait which is especially useful if you work with the generic
FileHandleabstraction.(削除) Furthermore, it splits up the existing integration test a little for a clearer separation of concerns. The simple file system protocol test now tests creating a file in the root volume. On this file, I test my newly created additions. (削除ここまで)(削除) Additionally,FileHandle::into_typenow returns a direct value instead of a Result. If we have a failure there, it is a hard-bug in the uefi-rs lib and not something the user should take care of. (削除ここまで)