Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Validate GOP test output with screenshots #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HadrienG2 merged 15 commits into rust-osdev:master from HadrienG2:screenshots
Sep 23, 2018
Merged

Validate GOP test output with screenshots #37

HadrienG2 merged 15 commits into rust-osdev:master from HadrienG2:screenshots
Sep 23, 2018

Conversation

Copy link
Contributor

@HadrienG2 HadrienG2 commented Sep 23, 2018
edited
Loading

As discussed in #1, it would be nice to add GOP test output validation to CI. This PR does so by using the "screendump" functionality of QEMU's monitor.

Implementing this had some side-effects:

  • (削除) Serial ports now implement fmt::Write for easily sending UTF-8 strings (削除ここまで) (removed)
  • The previous "qemu-f4-exit" feature was turned into a more general "qemu" feature which enables all the features that are specific to our QEMU-based test environment.
  • The python script can now chat with the QEMU monitor's JSON interface, which we could use later on for more advanced debugging features like core dumps.
  • I removed all temporizations from automated tests, so they will run a few seconds faster :)

Copy link
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HadrienG2 HadrienG2 merged commit 5431761 into rust-osdev:master Sep 23, 2018
@HadrienG2 HadrienG2 deleted the screenshots branch September 23, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielMajeri GabrielMajeri GabrielMajeri approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /