Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Annotated logs, stdout cleanup, and headless display #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HadrienG2 merged 3 commits into rust-osdev:master from HadrienG2:better-logging
Sep 23, 2018
Merged

Annotated logs, stdout cleanup, and headless display #32

HadrienG2 merged 3 commits into rust-osdev:master from HadrienG2:better-logging
Sep 23, 2018

Conversation

Copy link
Contributor

@HadrienG2 HadrienG2 commented Sep 22, 2018 •
edited
Loading

These improvements were mostly discussed in #1, with a couple of extra ideas I got since then:

  • uefi-logger's output is annotated with the log level on a line-by-line basis.
  • Headless vs non-headless QEmu configurations are now much closer to each other. Basically, the only difference is whether QEMU spawns an X11 window with the display or not.
  • The Python code intercepts QEMU's output and strips ANSI escape sequences from it before forwarding it to stdout, so the UEFI code cannot mess up your terminal anymore.

GabrielMajeri reacted with thumbs up emoji
Copy link
Collaborator

@GabrielMajeri GabrielMajeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You should be able to merge this yourself once you accept the collaborator invite.

Copy link
Contributor Author

I can indeed merge! Will wait a bit for the remaining discussions to settle before doing so.

@HadrienG2 HadrienG2 merged commit 220858b into rust-osdev:master Sep 23, 2018
@HadrienG2 HadrienG2 deleted the better-logging branch September 23, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielMajeri GabrielMajeri GabrielMajeri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /