uefi: Add bindings for the HII_CONFIG_ROUTING protocol #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

seijikun wants to merge 7 commits into rust-osdev:main

from seijikun:mr-hii-configrouting

Open

uefi: Add bindings for the HII_CONFIG_ROUTING protocol #1753

seijikun wants to merge 7 commits into rust-osdev:main from seijikun:mr-hii-configrouting

Conversation

seijikun

Copy link

Contributor

@seijikun seijikun commented Sep 3, 2025

I still had this lying around as experiment.
Polished it up a bit for the merge request.

It's best to review this commit-by-commit.

Checklist

Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
Update the changelog (if necessary)

@seijikun seijikun changed the title ~~(削除) Mr hii configrouting (削除ここまで)~~ (追記) uefi: Add bindings for the HII_CONFIG_ROUTING protocol (追記ここまで)

Sep 3, 2025

@seijikun seijikun force-pushed the mr-hii-configrouting branch 4 times, most recently from 6380ed3 to 2e556f1 Compare

September 4, 2025 15:05

phip1611

phip1611 reviewed

Sep 5, 2025

View reviewed changes

uefi/src/proto/hii/config_str.rs Outdated Show resolved Hide resolved

@seijikun seijikun force-pushed the mr-hii-configrouting branch from 2e556f1 to 0c54e18 Compare

September 10, 2025 15:21

phip1611

phip1611 approved these changes

Sep 13, 2025

View reviewed changes

Copy link

Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed everything and it LGTM! Thanks for working on this :) Left a few nits. Please answer my comments and then we are good to go

uefi/src/proto/hii/config_str.rs Show resolved Hide resolved

uefi/src/proto/hii/config_str.rs

let size_bytes = data.len() / 2 + 2; // includes 0円 terminator

let size_chars = size_bytes / 2;

let mut bfr = AlignedBuffer::from_size_align(size_bytes, 2).ok()?;

bfr.copy_from_iter(Self::parse_bytes_from_hex(data).chain([0, 0]));

Copy link

Member

@phip1611 phip1611 Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the [0, 0] some form of termiation?

Copy link

Contributor Author

@seijikun seijikun Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the [0, 0] bytes is a uint16 0.
I added the null terminator so that I could use the CStr16::from_u16_* APIs.
I must admit, I'm somewhat at odds with the entire UTF-16 string API surface of uefi.

uefi/src/mem/aligned_buffer.rs Show resolved Hide resolved

uefi/src/proto/hii/config_str.rs

};

let value = match splitter.next() {

Some(("VALUE", Some(data))) => Self::parse_bytes_from_hex(data).collect(),

Some(("VALUE", Some(data))) => Self::parse_bytes_from_hex(data).rev().collect(),

Copy link

Member

@phip1611 phip1611 Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why is it necessary to rev the bytes here??

Copy link

Contributor Author

@seijikun seijikun Sep 25, 2025 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment:

 // The uefi specification declares `VALUE` as being a "number" of arbitrary length.
 // And numbers have to be endianess-corrected. Thus, the bytes represented by a value's
 // hex string of arbitrary length have to be reversed to account for that weird encoding.

The short form is: "absolutely no idea. I checked it, and it's true" 😆
I've seen it stated somewhere else and was surprised that they were right.
https://github.com/Kostr/UEFI-Lessons/tree/master/Lessons_uncategorized/Lesson_Configuration_Language_5
^ This repo is worth more than gold!

seijikun added 3 commits

September 25, 2025 16:00

@seijikun


 uefi-raw: Add HII_CONFIG_ROUTING protocol bindings

0ac9805

@seijikun


 uefi: Add unit-test for ConfigurationString parsing

e4dddc6

@seijikun


 uefi: Fix unaligned memcpy in ConfigurationString parser

999e48d

@seijikun seijikun force-pushed the mr-hii-configrouting branch from 0c54e18 to 2977208 Compare

September 25, 2025 14:01

seijikun added 4 commits

September 25, 2025 16:04

@seijikun


 uefi: Fix ConfigurationString parsing needs to reverse VALUE bytes

3ca2dd1

@seijikun


 uefi: Add MultiConfigurationStringIter to handle UEFI <MultiConfigResp>

32fed3e

@seijikun


 uefi: Extend ConfigurationString parsing with alt_cfg_id variant

0e368cb

@seijikun


 uefi: Add safe bindings for HiiConfigRouting protocol

ef2b00d

@seijikun seijikun force-pushed the mr-hii-configrouting branch from 2977208 to ef2b00d Compare

September 25, 2025 14:04

Labels

None yet

2 participants

@seijikun @phip1611

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

uefi: Add bindings for the HII_CONFIG_ROUTING protocol #1753

Are you sure you want to change the base?

uefi: Add bindings for the HII_CONFIG_ROUTING protocol #1753

Uh oh!

Conversation

@seijikun seijikun commented Sep 3, 2025

Checklist

Uh oh!

Uh oh!

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@phip1611 phip1611 Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

@seijikun seijikun Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@phip1611 phip1611 Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

@seijikun seijikun Sep 25, 2025 •

edited

Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

uefi: Add bindings for the HII_CONFIG_ROUTING protocol #1753

Are you sure you want to change the base?

uefi: Add bindings for the HII_CONFIG_ROUTING protocol #1753

Uh oh!

Conversation

@seijikun seijikun commented Sep 3, 2025

Checklist

Uh oh!

Uh oh!

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@phip1611 phip1611 Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

@seijikun seijikun Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@phip1611 phip1611 Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

@seijikun seijikun Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@seijikun seijikun Sep 25, 2025 •

edited

Loading