Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added output to show what is happening. Made run command load any fi... #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rexlunae wants to merge 1 commit into rust-osdev:master from rexlunae:master

Conversation

Copy link
Contributor

@rexlunae rexlunae commented Jun 9, 2018

...rmware files from the path, allowing the use of unified firmware files such as those installed by Ubuntu's ovmf package.

...mware files from the path, allowing the use of unified firmware files such as those installed by Ubuntu's ovmf package.
Copy link
Contributor Author

rexlunae commented Jun 9, 2018

In getting the build script to work on Ubuntu, I discovered that the OVMF package that Ubuntu installs is different from whatever you are using, in that it has a single file. Because the existing build script assumes the existence of exactly two firmware files, I couldn't make it work unmodified. I think it makes more sense to allow any number of firmware files. With this change, all I have to do is make a soft link from the share directory to the build directory, and it works. It should still work with the separate OVMF_CODE.fd and OVMF_VARS.fd files, so this is simply adding functionality. Also, I added output showing what the script is doing, because I found this helpful in figuring out how and why the build was failing.

Copy link
Collaborator

GabrielMajeri commented Jun 10, 2018
edited
Loading

First of all, according to this page, Ubuntu's ovmf does come with two files, at least since xenial.

The issue here is that os.listdir returns files in arbitrary order, and we cannot be sure OVMF_CODE.fd comes before OVMF_VARS.fd. And if the first doesn't come in the command line before the latter, it won't boot. Sorting them might help.

I have no issue with the part of the pull request which outputs the commands.


I'd rather ask users of distros which haven't yet updated their packages, to use kraxel's repo, since that way they will at least have a fairly new version of UEFI, with fewer bugs.

Copy link
Contributor Author

rexlunae commented Jun 10, 2018 via email

Well, I definitely only got one file when I installed the package. But I'm on a Bionic, which is quite a bit newer than Xenial. But if the order of loading matters, this isn't a good approach, even if sorting would coincidentally make it work. So, I'd say disregard the pull request for now. I don't properly know how qemu's mechanism works for loading firmware.
...
On Sat, Jun 9, 2018, 22:37 Gabriel Majeri ***@***.***> wrote: First of all, according to this page <https://packages.ubuntu.com/xenial/all/ovmf/filelist>, Ubuntu's ovmf does come with two files, at least since xenial. The issue here is that os.listdir returns files in arbitrary order, and we cannot be sure OVMF_CODE.fd comes before OVMF_VARS.fd. And if the first doesn't come in the command line before the latter, it won't boot. Sorting them might help. ------------------------------ I'd rather ask users of distros which haven't yet updated their packages, to use kraxel's repo <https://www.kraxel.org/repos/jenkins/edk2/>, since that way they will at least have a fairly new version of UEFI, with fewer bugs. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGah9sFZ9sfdOTeCZzF4GKRcqB-KHKWKks5t7LCrgaJpZM4UhdgJ> .

Copy link
Collaborator

  • If you're Bionic, try to reinstall the package, or check to see if the /usr/share/OVMF directory contains the files (not /usr/share/ovmf, that's the old one - unix paths are case sensitive).

  • 7e9dbb7 adds command line printing for the build script.

  • fc7f85d adds a link to Gerd Hoffmann's repository of built QEMU binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /