-
Notifications
You must be signed in to change notification settings - Fork 218
Document physical memory mapping size #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freax13
Freax13
requested changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Co-authored-by: Tom Dohrmann <Erbse.13@gmx.de>
Freax13
Freax13
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
In developing an AHCI driver, I noticed that the addresses that UEFI loads the MMIO structures into were higher than the final memory region given by the memory map. Since I was using that final region to determine the size of the bootloader-provided physical memory map, I didn't know how far the map "truly" extended.
Digging into the source code (
common/src/legacy_memory_region.rs:141) I noticed that the bootloader continues mapping up to 4 GiB, even if less than that is on the system (I had QEMU set to 2). Since this didn't (seem to be) documented, I added a note to the rustdoc on the physical map settings explaining this. I took some of the wording from a comment on the relevant source code. Also, fixed a typo on the same rustdoc.