-
Notifications
You must be signed in to change notification settings - Fork 88
Improve stride copying in generalize a bit #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While still not perfect - that should be solved in upstream ndarray, the new version is an improvement since it checks the compatibility before attempting to construct the array. `.into_raw_vec()` is very hard to use correctly (this is inherent, it's an access to the raw memory model), so the new version will actually fail to convert in some cases that were passing as silent errors before (related to internally sliced arrays, rather uncommon).
@bluss
bluss
force-pushed
the
bluss/improve-generalize
branch
from
May 17, 2021 19:28
831dda2 to
831ecbe
Compare
Codecov Report
@@ Coverage Diff @@ ## master #288 +/- ## ========================================== + Coverage 89.01% 89.04% +0.03% ========================================== Files 71 71 Lines 3577 3579 +2 ========================================== + Hits 3184 3187 +3 + Misses 393 392 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While still not perfect - that should be solved in upstream ndarray, the
new version is an improvement since it checks the compatibility before
attempting to construct the array.
.into_raw_vec()is very hard to use correctly (this is inherent, it'san access to the raw memory model), so the new version will actually
fail to convert in some cases that were passing as silent errors before
(related to internally sliced arrays, rather uncommon).