-
Notifications
You must be signed in to change notification settings - Fork 88
Added eigg function which is a wrapper to ggev #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added doc comments for eigg function Added testcase
2119604 to
2d6ab5f
Compare
Codecov Report
@@ Coverage Diff @@ ## master #280 +/- ## ========================================= Coverage ? 88.86% ========================================= Files ? 71 Lines ? 3727 Branches ? 0 ========================================= Hits ? 3312 Misses ? 415 Partials ? 0
Continue to review full report at Codecov.
|
@termoshtt - could you please review this?
@termoshtt - I noticed that eigh is using (a,b).eigh() and my implementation is a.eigg(&b). For the former there is no documentation, so it is hard to find.
I can change my implementation to be consistent with it. That is change mine to (a,b).eig(). How do you prefer?
This is to resolve #267. It is equivalent of
eig(A,B)in Matlab