Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make lobpcg::MagnitudeCorrection public and improve documentation #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bytesnake wants to merge 8 commits into rust-ndarray:master
base: master
Choose a base branch
Loading
from bytesnake:lobpcg-fix

Conversation

Copy link
Contributor

@bytesnake bytesnake commented Apr 8, 2021
edited
Loading

Document the lobpcg module, fixes #274:

  • Make MagnitudeCorrection public
  • Improve documentation for TruncatedEig
  • Improve documentation for TruncatedSvd
  • Add Marchensko-Pastur law test

relf reacted with thumbs up emoji
Copy link

codecov bot commented Apr 8, 2021
edited
Loading

Codecov Report

Merging #275 (451ed8e) into master (aee87d9) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 88.95% 89.18% +0.23% 
==========================================
 Files 71 71 
 Lines 3557 3578 +21 
==========================================
+ Hits 3164 3191 +27 
+ Misses 393 387 -6 
Impacted Files Coverage Δ
ndarray-linalg/src/lobpcg/eig.rs 75.38% <ø> (ø)
ndarray-linalg/src/lobpcg/lobpcg.rs 93.30% <ø> (+1.18%) ⬆️
ndarray-linalg/src/lobpcg/svd.rs 91.26% <100.00%> (+5.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee87d9...451ed8e. Read the comment docs.

@relf relf mentioned this pull request Apr 8, 2021
3 tasks
@bytesnake bytesnake marked this pull request as ready for review April 14, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@termoshtt termoshtt Awaiting requested review from termoshtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MagnitudeCorrection trait should be public
1 participant

AltStyle によって変換されたページ (->オリジナル) /