-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
92d8dd5 to
fb3e7d8
Compare
xorgy
commented
Oct 29, 2025
I've gone ahead and run this, the primary view demo works well but I'm not 100% sure of the Masonry demo. It seems to let me focus in and type but I'd like a second set of eyes on it.
@PoignardAzur
PoignardAzur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, aside from the layer handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can make this code slightly more readable with Button::with_text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could use the crates.io release instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't exist at that point 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and also that has to go in the ui-events 0.2.0 PR, because that's a separate set of changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't know how to handle those, you should replicate the version in masonry_winit which calls RenderRoot::add_layer and the like. We should probably document this in Masonry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, thanks.
xorgy
commented
Nov 5, 2025
This needs a look from somebody who is actually familiar with this stuff, because it is crashing; and crashing in a way that I am not currently set up to debug.
No description provided.