-
Notifications
You must be signed in to change notification settings - Fork 5
feat: enhance CallToolError API and add is_initialized_notification to Relevant Client Message Types #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant Client Message Types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
This PR introduces two main improvements: Improving
CallToolErrorergonomics and structure and addingis_initialized_notificationto Relevant Client Message Types.β¨ Changes Made
CallToolErrorKindto categorize error types (InvalidInput,UnknownTool, etc.).from_messageconstructor to support generating ad-hoc or one-off errors without defining a custom error type.invalid_argumentsconstructor to streamline invalid tool input error creation.is_initialized_notificationto bothMessageFromClientandClientMessageenums to easily detect the initialized notification without matching the variants.π‘ Additional Notes
Added
rust-toolchain.tomlto pin the Rust version for consistent builds and CI compatibility.