-
Notifications
You must be signed in to change notification settings - Fork 5
Support validation for method fields in *Request
#81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zhongyi51
zhongyi51
changed the title
(削除) Support validation for subtypes of
(追記) Support validation for method field in Jul 19, 2025
*Request
enums (ServerRequest as an example) (削除ここまで)*Request
(追記ここまで)
@zhongyi51
zhongyi51
changed the title
(削除) Support validation for method field in
(追記) Support validation for method fields in Jul 19, 2025
*Request
(削除ここまで)*Request
(追記ここまで)
Update: It has been a long time and my focus was on other priority features of the SDK. I started adding these changes into schema generator and will update this PR soon 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #75
The Problem
As identified in issue #75, the individual
*Request
structs (e.g.,PingRequest
,ListResourcesRequest
) do not currently validate that theirmethod
field matches the constant value defined in the JSON schema. This creates ambiguity. For example, a JSON payload like:could be incorrectly deserialized as a
ListResourcesRequest
. The deserialization process should fail fast if themethod
name is incorrect for the target struct.The Solution
This pull request proposes a robust pattern to validate the
method
field by leveraging Serde's#[serde(deserialize_with = "...")]
:Note for Maintainers