-
Notifications
You must be signed in to change notification settings - Fork 557
glossary: add entry for rustbuild #2516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using r? rustc-dev-guide
or r? <username>
.
I see it more as the old name, I'd call the rust part bootstrap too
Yes, I would say bootstrap is the whole system of bootstrap.py + rustbuild.
The name "rustbuild" still gets used a fair bit by t-bootstrap when the distinction between the two parts is meaningful. I honestly had no idea the history of the name, I just noticed it was a term people were using that didn't seem to be written down anywhere really.
I don't think this is actually used that way? At least, I don't use rustbuild to refer to the rust part, I call that bootstrap
, and disambiguate from the python part by calling the python part bootstrap.py
or "the python wrapper" etc. etc.
i think having the entry is ok as a reference. i agree we should be consistent in the docs themselves, but i think a glossary entry doesn't hurt, since it will come up occasionally in old issues.
How about having this entry, but mentioning that it’s an old deprecated term?
bd61134
to
2a48618
Compare
-
This PR is based on an upstream commit that is older than 7 days.
It's recommended to update your branch according to the rustc-dev-guide.
Mentioned the term is deprecated.
Co-authored-by: Tshepang Mbambo <hopsi@tuta.io>
No description provided.