Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

remove "Easy" and "good-first-issue" from help-wanted-search #2409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyn514 wants to merge 1 commit into rust-lang:master
base: master
Choose a base branch
Loading
from jyn514:search

Conversation

Copy link
Member

@jyn514 jyn514 commented May 23, 2025
edited
Loading

previously, they gave a warning about being "invalid filters". that seems like a github bug, because they were definitely present in the clippy and reference repos, but i worked around it by asking clippy and the reference to change to E-easy and good first issue instead. update the search now, so that people don't see a warning.

previously, they gavea a warning about being "invalid filters". that
seems like a github bug, because they were definitely present in the
clippy and reference repos, but i worked around it by asking clippy and
the reference to change to `E-easy` and `good first issue` instead.
update the search now, so that people don't see a warning.
Copy link
Member Author

jyn514 commented May 23, 2025
edited
Loading

the warnings: image

Copy link
Member

why I search with the new link will get these warnings:

image

emm, github bug?

Copy link
Member

dianqk commented May 24, 2025

The new link looks good to me.
image

Copy link
Member

Somehow I get a different result than both of you:

Screenshot 2025年05月27日 022857

Copy link
Member Author

jyn514 commented May 26, 2025

I agree that something fishy is going on here (probably github's search Javascript is picking a random repository to determine which labels exist), but can we agree that this PR is a strict improvement over the status quo?

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks

Copy link
Member

jieyouxu commented May 27, 2025
edited
Loading

(#2413 also updated it to account for glacier)

(I can't push to ur branch so)

dianqk reacted with thumbs up emoji

@jieyouxu jieyouxu added S-waiting-on-author Status: this PR is waiting for additional action by the OP WG-rustc-dev-guide Working group: rustc-dev-guide labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: this PR is waiting for additional action by the OP WG-rustc-dev-guide Working group: rustc-dev-guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /