-
Notifications
You must be signed in to change notification settings - Fork 558
Add overview.drawio.svg #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overview.drawio.svg #1725
Conversation
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
* Update `traits/resolution.md` Co-authored by: @lcnr and @spastorino * Update src/traits/resolution.md * Wrapping * Update src/traits/resolution.md Co-authored-by: Santiago Pastorino <spastorino@gmail.com> Co-authored-by: Santiago Pastorino <spastorino@gmail.com>
According to rust-lang/rust@8873e33 > Running with --bless causes the push to succeed if there are fixable formatting changes, but the changes don't make it into the push. > > We should have the user rerun with --bless (or x.py fmt) and commit the changes themselves (they might want to amend a particular commit, for instance).
Updated Diagnostic text to use the same language used in Subdiagnostic
* Fix some typos. Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>
- queries always need a description - `QueryDescription` isn't just for descriptions (it's actually not for descriptions at all now) and always implemented by the macro - queries are not grouped into categories
Co-authored-by: Tshepang Mbambo <tshepang@gmail.com>
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
rust-lang/project-const-generics#21 removed the link. This replaces it with an issue link mentioned on the design docs. Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Updates the location of the `try_mark_green` algorithm from `compiler/rustc_middle/src/dep_graph/graph.rs` to [`compiler/rustc_middle/src/dep_graph/graph.rs`](https://github.com/rust-lang/rust/blob/stable/compiler/rustc_query_system/src/dep_graph/graph.rs#L574) .
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
`-C incremental` is sound and --keep-stage is not.
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
I think it's better to convert this file to something like .drawio.svg. By doing so, we can view the diagram on GitHub. The SVG file is editable on draw.io and can be embedded on Github.
ref:
Cool, first time knowing that, thanks :-)
Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new master):
git fetch origin --all
git checkout <pr-branch>
git rebase --onto origin/master origin/master-old
git push --force-with-lease
More context can be found here.
Hi, thank you for your contribution and sorry for the lack of reviews. Given that unfortunately this has accrued a lot of conflicts and seems unlikely to receive a meaningful review anytime soon, I will close this PR for now.
draw.io: https://www.drawio.com/
I used to do some notes using these kind of files, they are easy to use and their size is affordable. Since I haven't seen such graphs about the rustc, I did this myself hoping it could be a help for anyone who wants to get to know the arch of the rustc and its workflow.
Currently I've just placed it in
src/drawio/overview.drawioas I think this might be a good place to store such kind of files.You can edit
*.drawioby VSCode extension or online:图片
I'm new to rustc so the
overview.drawiomight not be entirely correct, and I wish that someone could fix it or add more info about the rustc :-)