-
Notifications
You must be signed in to change notification settings - Fork 557
add tool to "enforce" semantic line breaks #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No migrations were necessary.
This commit adds initial documentation for LLVM Control Flow Integrity (CFI) support to the Rust compiler (see rust-lang/rust#89652 and rust-lang/rust#89653).
Co-authored-by: Yuki Okushi <jtitor@2k36.org> Co-authored-by: nhamovitz <18648574+nhamovitz@users.noreply.github.com>
This is work toward rust-lang#1241.
Use paragraphs instead of bullet-points. Edits throughout for clarity. Use semantic line breaks in edited sections. Co-authored-by: Joshua Nelson <github@jyn.dev>
This should prevent future failures like this one [1]. [1]: https://github.com/rust-lang/rustc-dev-guide/runs/4067460927?check_suite_focus=true
I removed one of them because it doesn't seem necessary.
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
The italics added in rust-lang#1239 broke the implicitly-resolved link.
* Fix broken links in region_inference.md * Fix broken links in lifetime_parameters.md
Co-authored-by: pierwill <19642016+pierwill@users.noreply.github.com>
The proc-macro server path is required for proc-macros to properly work in r-a when working on rustc. Pointing the sysroot to the stage0 one is more correct than using the system installed one.
Previously, "Building and debugging `rustc`" linked to the getting started page, which isn't correct. If people want that page, it already appears in the sidebar, and is the next sequential page.
Co-authored-by: mejrs <>
When doing a git grep (of rustc-dev-guide or of rust-lang/rust with --recurse-submodules), if the grep happens to match within the minified javascript, the resulting long single lines can cause a text pager or editor to slow down and distract from more useful matches. Minified javascript isn't formatted for human consumption, by definition, so mark it as binary, which causes git grep to instead just state that it matches without printing the matching "line".
Using `llvm.godbolt.org` subdomain should automatically select the correct LLVM-IR language.
d1feea4 to
19d2632
Compare
I don't have an objection to enforcing sembr but the implementation does look fragile, e.g. there's no tokenizer. Have you considered using an existing tool like https://github.com/bobheadxi/readable?
I have not... thanks for the suggestion, will have a look.
I have tried using readable to have a GitHub action that runs check, and format all the existing code, but the tool is immature, it gave errors for some files saying Cannot take length of multi-line node '[object Object]' (bobheadxi/readable#18) and for others the aforementioned issue is there, it does the wrong thing when it encounters e.g.(bobheadxi/readable#17). I am not sure what should be done here, make readable better or create another tool?
This tool of mine handles both issues without choking. I intend to get back to making it more fancy... I keep postponing.
Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new master):
git fetch origin --all
git checkout <pr-branch>
git rebase --onto origin/master origin/master-old
git push --force-with-lease
More context can be found here.
Uh oh!
There was an error while loading. Please reload this page.
See #1132
Run it so:
Diff is large, so maybe should be automated.