-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Report opaque type mismatches directly during borrowck of the function instead of within the type_of query.
#95767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 2 commits into
rust-lang:master
from
oli-obk:all_your_generics_belong_to_the_definitions
Apr 7, 2022
Merged
Report opaque type mismatches directly during borrowck of the function instead of within the type_of query.
#95767
bors
merged 2 commits into
rust-lang:master
from
oli-obk:all_your_generics_belong_to_the_definitions
Apr 7, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...n instead of within the `type_of` query. This allows us to only store a single hidden type per opaque type instead of having to store one per set of substitutions.
@rustbot
rustbot
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Apr 7, 2022
@rust-highfive
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 7, 2022
@oli-obk
oli-obk
added
the
A-diagnostics
Area: Messages for errors, warnings, and lints
label
Apr 7, 2022
@bors r+
📌 Commit 7d2cad6 has been approved by compiler-errors
@bors
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 7, 2022
@bors rollup=never
☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing e745b4d to master...
|
Finished benchmarking commit (e745b4d): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to only store a single hidden type per opaque type instead of having to store one per set of substitutions.
r? @compiler-errors
This does not affect diagnostics, because the diagnostic messages are exactly the same.