Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Rollup of 4 pull requests #146862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 9 commits into rust-lang:master from matthiaskrgr:rollup-1zqootr
Sep 21, 2025
Merged

Rollup of 4 pull requests #146862

bors merged 9 commits into rust-lang:master from matthiaskrgr:rollup-1zqootr
Sep 21, 2025

Conversation

Copy link
Member

@matthiaskrgr matthiaskrgr commented Sep 21, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

pvdrz and others added 9 commits September 16, 2025 10:26 
Co-authored-by: Anne Stijns <anstijns@gmail.com>
All platforms define this structure the same way, so we can just put it in the `process` module directly.
...zelmann
Port #[macro_export] to the new attribute parsing infrastructure
Ports macro_export to the new attribute parsing infrastructure for rust-lang#131229 (comment)
r? ``@oli-obk``
cc ``@JonathanBrouwer`` ``@jdonszelmann``
...erage, r=ibraheemdev
Improve `core::sync::atomic` coverage
This PR improves the `core::sync::atomic` coverage by adding new tests to `coretests`.
r? libs
...ulacrum
ci: x86_64-gnu-tools: Add `--test-args` regression test
See rust-lang#146601 (comment)
r? ``@Mark-Simulacrum``
...imulacrum
std: merge definitions of `StdioPipes`
All platforms define this structure the same way, so we can just put it in the `process` module directly.
@rustbot rustbot added A-attributes Area: Attributes (`#[...]`, `#![...]`) A-CI Area: Our Github Actions CI A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. rollup A PR which is a rollup labels Sep 21, 2025
Copy link
Member Author

@bors r+ rollup=never p=5

Copy link
Collaborator

bors commented Sep 21, 2025

📌 Commit adfc111 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2025
Copy link
Collaborator

bors commented Sep 21, 2025

⌛ Testing commit adfc111 with merge 9f32ccf...

Copy link
Collaborator

bors commented Sep 21, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 9f32ccf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 21, 2025
@bors bors merged commit 9f32ccf into rust-lang:master Sep 21, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 21, 2025
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#143857 Port #[macro_export] to the new attribute parsing infrastru... 483ee2be2d8827f9f3aea0256aceac3eea761edd (link)
#146486 Improve core::sync::atomic coverage 0060a63cdf5ce9f5968641be656d90f3ff44544e (link)
#146606 ci: x86_64-gnu-tools: Add --test-args regression test c7c1c6fbc55a66f3632e29aaa06118941a7aa28a (link)
#146639 std: merge definitions of StdioPipes b2c0c1a377257209da095c0b4f7883165f2e1892 (link)

previous master: 7e4b8d702f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7e4b8d7 (parent) -> 9f32ccf (this PR)

Test differences

Show 691 test diffs

Stage 0

  • errors::verify_passes_abi_of_91: pass -> [missing] (J0)
  • errors::verify_passes_attr_application_struct_103: [missing] -> pass (J0)
  • errors::verify_passes_attr_application_struct_enum_union_105: [missing] -> pass (J0)
  • errors::verify_passes_attr_application_struct_union_104: [missing] -> pass (J0)
  • errors::verify_passes_attr_only_in_functions_97: pass -> [missing] (J0)
  • errors::verify_passes_collapse_debuginfo_74: pass -> [missing] (J0)
  • errors::verify_passes_custom_mir_phase_requires_dialect_143: pass -> [missing] (J0)
  • errors::verify_passes_feature_previously_declared_93: [missing] -> pass (J0)
  • errors::verify_passes_feature_previously_declared_96: pass -> [missing] (J0)
  • errors::verify_passes_ineffective_unstable_impl_126: [missing] -> pass (J0)
  • errors::verify_passes_lang_item_fn_with_target_feature_78: [missing] -> pass (J0)
  • errors::verify_passes_lang_item_fn_with_track_caller_77: [missing] -> pass (J0)
  • errors::verify_passes_lang_item_fn_with_track_caller_80: pass -> [missing] (J0)
  • errors::verify_passes_lang_item_on_incorrect_target_79: [missing] -> pass (J0)
  • errors::verify_passes_lang_item_on_incorrect_target_82: pass -> [missing] (J0)
  • errors::verify_passes_layout_abi_85: pass -> [missing] (J0)
  • errors::verify_passes_layout_align_83: [missing] -> pass (J0)
  • errors::verify_passes_layout_homogeneous_aggregate_85: [missing] -> pass (J0)
  • errors::verify_passes_layout_of_86: [missing] -> pass (J0)
  • errors::verify_passes_layout_size_84: [missing] -> pass (J0)
  • errors::verify_passes_macro_export_on_decl_macro_64: [missing] -> pass (J0)
  • errors::verify_passes_macro_export_on_decl_macro_65: pass -> [missing] (J0)
  • errors::verify_passes_missing_const_err_121: pass -> [missing] (J0)
  • errors::verify_passes_missing_lang_item_79: pass -> [missing] (J0)
  • errors::verify_passes_missing_panic_handler_77: pass -> [missing] (J0)
  • errors::verify_passes_multiple_rustc_main_98: pass -> [missing] (J0)
  • errors::verify_passes_object_lifetime_err_104: pass -> [missing] (J0)
  • errors::verify_passes_panic_unwind_without_std_78: pass -> [missing] (J0)
  • errors::verify_passes_repr_align_should_be_align_static_139: [missing] -> pass (J0)
  • errors::verify_passes_rustc_const_stable_indirect_pairing_132: pass -> [missing] (J0)
  • errors::verify_passes_sanitize_attribute_not_allowed_128: [missing] -> pass (J0)
  • errors::verify_passes_trait_impl_const_stable_113: [missing] -> pass (J0)
  • errors::verify_passes_trait_impl_const_stable_116: pass -> [missing] (J0)
  • errors::verify_passes_unexportable_fn_abi_136: pass -> [missing] (J0)
  • errors::verify_passes_unexportable_item_134: pass -> [missing] (J0)
  • errors::verify_passes_unknown_external_lang_item_73: [missing] -> pass (J0)
  • errors::verify_passes_unrecognized_argument_91: [missing] -> pass (J0)
  • errors::verify_passes_unstable_attr_for_already_stable_feature_110: [missing] -> pass (J0)
  • errors::verify_passes_unstable_attr_for_already_stable_feature_113: pass -> [missing] (J0)
  • errors::verify_passes_unsupported_attributes_in_where_133: pass -> [missing] (J0)
  • errors::verify_passes_unused_duplicate_70: pass -> [missing] (J0)

Stage 1

  • errors::verify_passes_abi_invalid_attribute_93: pass -> [missing] (J1)
  • errors::verify_passes_attr_application_enum_102: [missing] -> pass (J1)
  • errors::verify_passes_attr_application_enum_105: pass -> [missing] (J1)
  • errors::verify_passes_attr_application_struct_103: [missing] -> pass (J1)
  • errors::verify_passes_attr_application_struct_106: pass -> [missing] (J1)
  • errors::verify_passes_attr_application_struct_enum_union_108: pass -> [missing] (J1)
  • errors::verify_passes_attr_only_in_functions_97: pass -> [missing] (J1)
  • errors::verify_passes_cannot_stabilize_deprecated_109: [missing] -> pass (J1)
  • errors::verify_passes_collapse_debuginfo_71: [missing] -> pass (J1)
  • errors::verify_passes_const_stable_not_stable_122: pass -> [missing] (J1)
  • errors::verify_passes_custom_mir_phase_requires_dialect_143: pass -> [missing] (J1)
  • errors::verify_passes_duplicate_feature_err_117: [missing] -> pass (J1)
  • errors::verify_passes_extern_main_99: pass -> [missing] (J1)
  • errors::verify_passes_feature_stable_twice_95: pass -> [missing] (J1)
  • errors::verify_passes_implied_feature_not_exist_116: [missing] -> pass (J1)
  • errors::verify_passes_implied_feature_not_exist_119: pass -> [missing] (J1)
  • errors::verify_passes_inline_ignored_for_exported_100: [missing] -> pass (J1)
  • errors::verify_passes_invalid_macro_export_arguments_66: pass -> [missing] (J1)
  • errors::verify_passes_lang_item_fn_with_target_feature_81: pass -> [missing] (J1)
  • errors::verify_passes_lang_item_on_incorrect_target_79: [missing] -> pass (J1)
  • errors::verify_passes_layout_align_86: pass -> [missing] (J1)
  • errors::verify_passes_layout_homogeneous_aggregate_85: [missing] -> pass (J1)
  • errors::verify_passes_macro_export_64: pass -> [missing] (J1)
  • errors::verify_passes_may_dangle_66: [missing] -> pass (J1)
  • errors::verify_passes_may_dangle_69: pass -> [missing] (J1)
  • errors::verify_passes_missing_const_err_121: pass -> [missing] (J1)
  • errors::verify_passes_missing_lang_item_76: [missing] -> pass (J1)
  • errors::verify_passes_non_exported_macro_invalid_attrs_65: [missing] -> pass (J1)
  • errors::verify_passes_non_exported_macro_invalid_attrs_68: pass -> [missing] (J1)
  • errors::verify_passes_panic_unwind_without_std_75: [missing] -> pass (J1)
  • errors::verify_passes_panic_unwind_without_std_78: pass -> [missing] (J1)
  • errors::verify_passes_rustc_const_stable_indirect_pairing_132: pass -> [missing] (J1)
  • errors::verify_passes_rustc_lint_opt_ty_72: pass -> [missing] (J1)
  • errors::verify_passes_sanitize_attribute_not_allowed_128: [missing] -> pass (J1)
  • errors::verify_passes_unexportable_adt_with_private_fields_137: [missing] -> pass (J1)
  • errors::verify_passes_unexportable_item_134: pass -> [missing] (J1)
  • errors::verify_passes_unexportable_type_repr_134: [missing] -> pass (J1)
  • errors::verify_passes_unexportable_type_repr_137: pass -> [missing] (J1)
  • errors::verify_passes_unknown_feature_114: [missing] -> pass (J1)
  • errors::verify_passes_unknown_feature_117: pass -> [missing] (J1)
  • errors::verify_passes_unknown_lang_item_83: pass -> [missing] (J1)
  • errors::verify_passes_unnecessary_stable_feature_127: pass -> [missing] (J1)
  • errors::verify_passes_unreachable_due_to_uninhabited_121: [missing] -> pass (J1)
  • errors::verify_passes_unstable_attr_for_already_stable_feature_110: [missing] -> pass (J1)
  • errors::verify_passes_unsupported_attributes_in_where_130: [missing] -> pass (J1)
  • errors::verify_passes_unsupported_attributes_in_where_133: pass -> [missing] (J1)
  • errors::verify_passes_unused_capture_maybe_capture_ref_123: [missing] -> pass (J1)
  • errors::verify_passes_unused_capture_maybe_capture_ref_126: pass -> [missing] (J1)
  • errors::verify_passes_unused_duplicate_67: [missing] -> pass (J1)
  • errors::verify_passes_unused_duplicate_70: pass -> [missing] (J1)
  • errors::verify_passes_unused_var_maybe_capture_ref_122: [missing] -> pass (J1)
  • atomic::atomic_compare_exchange_weak_illegal_release: [missing] -> pass (J2)
  • atomic::atomic_min: [missing] -> pass (J2)
  • atomic::atomic_sub: [missing] -> pass (J2)
  • atomic::atomic_umax: [missing] -> pass (J2)
  • atomic::store_illegal_rt_store_acq_rel_ordering: [missing] -> pass (J2)

Stage 2

  • atomic::atomic_compare_exchange_illegal_release: [missing] -> pass (J3)
  • atomic::atomic_umin: [missing] -> pass (J3)
  • atomic::atomic_xor: [missing] -> pass (J3)

(and 255 additional test diffs)

Additionally, 336 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
 test-dashboard 9f32ccf35fb877270bc44a86a126440f04d676d0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1353.2s -> 1697.0s (25.4%)
  2. dist-aarch64-linux: 8443.8s -> 6714.0s (-20.5%)
  3. x86_64-rust-for-linux: 2531.5s -> 2997.6s (18.4%)
  4. pr-check-2: 2210.3s -> 2524.9s (14.2%)
  5. x86_64-gnu-llvm-20: 2414.6s -> 2746.1s (13.7%)
  6. i686-gnu-1: 7460.6s -> 8440.9s (13.1%)
  7. x86_64-gnu-llvm-20-2: 5554.4s -> 6280.8s (13.1%)
  8. aarch64-apple: 4910.0s -> 5542.1s (12.9%)
  9. i686-gnu-nopt-1: 7181.6s -> 8054.8s (12.2%)
  10. i686-gnu-2: 5564.8s -> 6154.4s (10.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Copy link
Collaborator

Finished benchmarking commit (9f32ccf): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.2%, secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)		 3.2% [0.6%, 4.5%] 4
Improvements ✅
(primary)		 -3.2% [-3.6%, -2.5%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.2% [-3.6%, 0.7%] 4

Cycles

Results (secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [1.9%, 3.0%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.9% [-4.9%, -4.9%] 1
All ❌✅ (primary) - - 0

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Bootstrap: 471.863s -> 471.273s (-0.13%)
Artifact size: 387.93 MiB -> 387.92 MiB (-0.00%)

Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025 
...iaskrgr
Rollup of 4 pull requests
Successful merges:
 - rust-lang#143857 (Port #[macro_export] to the new attribute parsing infrastructure)
 - rust-lang#146486 (Improve `core::sync::atomic` coverage)
 - rust-lang#146606 (ci: x86_64-gnu-tools: Add `--test-args` regression test)
 - rust-lang#146639 (std: merge definitions of `StdioPipes`)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-attributes Area: Attributes (`#[...]`, `#![...]`) A-CI Area: Our Github Actions CI A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /