-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Rollup of 4 pull requests #146304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #146304
Conversation
It is only used within cg_llvm.
It is always false nowadays. ThinLTO summary writing is instead done by llvm_optimize.
Upstream Solaris flock emulation to libstd from cargo. This is borrowed from https://github.com/rust-lang/cargo/blob/3b379fcc541b39321a7758552d37e5e0cc4277b9/src/cargo/util/flock.rs#L502-L536 which was implemented by an Oracle employee. The code has been in cargo since 2022-12. Python's `fcntl.flock` emulates like this as well: https://github.com/python/cpython/blob/c919d02edecfe9d75fe374756fb8aa1db8d95f55/Modules/fcntlmodule.c#L337-L400 We did the same thing in https://github.com/rust-lang/rust/blob/0d0f4eac8b98133e5da6d3604d86a8f3b5a67844/compiler/rustc_data_structures/src/flock/unix.rs#L13-L39
...crum fix: offline rustdoc html missing favicon As discussed in the rust-lang#146149 the doc was missing the favicon icon when build locally and viewed on a browser. I changed the relative path and also now we explicitly copy both SVG and PNG. <img width="1132" height="425" alt="Screenshot 2025年09月03日 at 11 57 46 PM" src="https://github.com/user-attachments/assets/062cbb08-04ec-4d88-a43a-710fb6190f82" />
Misc LTO cleanups Follow up to rust-lang#145955. * Remove want_summary argument from `prepare_thin`. Since rust-lang#133250 ThinLTO summary writing is instead done by `llvm_optimize`. * Two minor cleanups
...mulacrum feat(std): emulate flock for solaris via fcntl Upstream Solaris flock emulation to libstd from cargo. This is borrowed from https://github.com/rust-lang/cargo/blob/3b379fcc541b39321a7758552d37e5e0cc4277b9/src/cargo/util/flock.rs#L502-L536 which was implemented by an Oracle employee. The code has been in cargo since 2022-12. Python's `fcntl.flock` emulates like this as well: https://github.com/python/cpython/blob/c919d02edecfe9d75fe374756fb8aa1db8d95f55/Modules/fcntlmodule.c#L337-L400 We did the same thing in https://github.com/rust-lang/rust/blob/0d0f4eac8b98133e5da6d3604d86a8f3b5a67844/compiler/rustc_data_structures/src/flock/unix.rs#L13-L39 However, should we just always falls back to fcntl for all Unix, instead of "unsupported"? try-job: `*-solaris`
...ethlin Introduce PlaceContext::may_observe_address. A small utility method to avoid open-coding the logic in several MIR opts.
@bors r+ rollup=never p=5
☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 12eb345 to master...
|
📌 Perf builds for each rolled up PR:
previous master: 23718020b1 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 2371802 (parent) -> 12eb345 (this PR)
Test differences
Show 2 test diffs
2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \ test-dashboard 12eb345e5593a10e61b4aef766076c8bd552fea6 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
- dist-apple-various: 4827.5s -> 3630.0s (-24.8%)
- dist-x86_64-apple: 8473.4s -> 6653.6s (-21.5%)
- pr-check-1: 1368.2s -> 1626.5s (18.9%)
- dist-aarch64-apple: 6302.3s -> 7268.1s (15.3%)
- x86_64-rust-for-linux: 2587.0s -> 2920.8s (12.9%)
- x86_64-gnu-llvm-19-1: 3315.0s -> 3715.3s (12.1%)
- aarch64-gnu: 6583.1s -> 7336.0s (11.4%)
- x86_64-gnu-tools: 3300.2s -> 3663.5s (11.0%)
- aarch64-gnu-llvm-19-2: 2245.5s -> 2492.3s (11.0%)
- i686-gnu-1: 7348.7s -> 8100.5s (10.2%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.
|
Finished benchmarking commit (12eb345): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.5%, secondary 1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 467.642s -> 468.162s (0.11%) |
Uh oh!
There was an error while loading. Please reload this page.
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup