-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Support #[rustc_align_static] inside thread_local!
#146281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jules-Bertholet
wants to merge
2
commits into
rust-lang:master
from
Jules-Bertholet:static-align-thread-local
Open
Support #[rustc_align_static] inside thread_local!
#146281
Jules-Bertholet
wants to merge
2
commits into
rust-lang:master
from
Jules-Bertholet:static-align-thread-local
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a different attribute than `rustc_align` because unstable attributes are tied to their feature (we can't have two unstable features use the same unstable attribute). Otherwise this uses all of the same infrastructure as `#[rustc_align]`.
@rustbot
rustbot
added
A-attributes
Area: Attributes (`#[...]`, `#![...]`)
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Sep 6, 2025
Some changes occurred in compiler/rustc_attr_parsing
Some changes occurred in compiler/rustc_codegen_gcc
Some changes occurred to the CTFE machinery
Some changes occurred to the CTFE / Miri interpreter
cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr
Some changes occurred in compiler/rustc_passes/src/check_attr.rs
Some changes occurred to the CTFE / Miri interpreter
cc @rust-lang/miri
The Miri subtree was changed
cc @rust-lang/miri
@rustbot
rustbot
added
A-macros
Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
A-thread-locals
Area: Thread local storage (TLS)
F-static_align
#![feature(static_align)]
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
labels
Sep 6, 2025
@Jules-Bertholet
Jules-Bertholet
force-pushed
the
static-align-thread-local
branch
from
September 6, 2025 17:14
67db3cb to
dd3475c
Compare
@rustbot
rustbot
added
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
and removed
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
labels
Sep 6, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Tracking issue: #146177
This increases the amount of recursion the macro performs (once per attribute in addition to the previous once per item), making it easier to hit the recursion limit. I’ve added workarounds to limit the impact in the case of long doc comments, but this still needs a crater run just in case.
r? libs
@rustbot label A-attributes A-macros A-thread-locals F-static_align T-libs
Blocked on #146178; @rustbot blocked