Skip to content

Fix hidden glob reexports 146164 #146212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

sitetester wants to merge 4 commits into rust-lang:master

from sitetester:fix-hidden-glob-reexports-146164

+11 −0

Open

Fix hidden glob reexports 146164 #146212

Changes from all commits

Commits

Show all changes

Select commit Hold shift + click to select a range

Fix false positive in hidden_glob_reexports lint

sitetester Sep 4, 2025

Add //@ check-pass, as now code should compile successfully without a...

sitetester Sep 4, 2025

Remove redundant comment

sitetester Sep 6, 2025

Fix false positive in hidden_glob_reexports lint

sitetester Sep 6, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

1 change: 1 addition & 0 deletions compiler/rustc_resolve/src/imports.rs

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -677,6 +677,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
		{
		if binding.res() != Res::Err
		&& glob_binding.res() != Res::Err
	&& binding.res() != glob_binding.res() // Only warn if they're different items
		&& let NameBindingKind::Import { import: glob_import, .. } =
		glob_binding.kind
		&& let Some(glob_import_id) = glob_import.id()
Expand Down

10 changes: 10 additions & 0 deletions tests/ui/lint/hidden-glob-reexports-issue-146164.rs

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,10 @@
	//@ check-pass
	// Test that hidden_glob_reexports lint doesn't warn when importing the same item
	// that's already available through a glob re-export

	pub use std::option::*;
	use std::option::Option;

	fn main() {
	let _x: Option<i32> = Some(42);
	}

Loading