-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Update bootstrap's dependencies to remove winapi and old windows-sys #146168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+108
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Sep 3, 2025
@dpaoliello
dpaoliello
force-pushed
the
bootstrapdeps
branch
from
September 3, 2025 17:24
4c7b4ec to
31d1d82
Compare
FYI, I'm also looking into the dependencies that are pulling in windows-sys 0.59 to see if they can move to 0.60 so that bootstrap can use a single version.
FYI, I'm also looking into the dependencies that are pulling in
windows-sys0.59 to see if they can move to 0.60 so that bootstrap can use a single version.
Would that remove the duplicate windows-targets?
Would that remove the duplicate windows-targets?
Yep
@bors try jobs=aarch64-msvc-1,x86_64-msvc-1
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 4, 2025
Update bootstrap's dependencies to remove winapi and old windows-sys try-job: aarch64-msvc-1 try-job: x86_64-msvc-1
jieyouxu
jieyouxu
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bors r+ rollup
@bors
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 4, 2025
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 4, 2025
Update bootstrap's dependencies to remove winapi and old windows-sys Bumps `opener` to 0.8 and `junction` to 1.3 - this removes the dependency on `winapi` (unless the `build-metrics` feature is enabled) and replaces the usage of `windows-sys` 0.52 with 0.60. Together this means that bootstrap can now be built for Arm64EC.
bors
added a commit
that referenced
this pull request
Sep 4, 2025
Rollup of 5 pull requests Successful merges: - #145682 (Promote aarch64-pc-windows-msvc to Tier 1) - #145690 (Implement Integer funnel shifts) - #146119 (compiletest: Implement an experimental `--new-output-capture` mode) - #146168 (Update bootstrap's dependencies to remove winapi and old windows-sys) - #146182 (Don't require next-solver `ProbeRef` to be `Copy`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 4, 2025
Rollup merge of #146168 - dpaoliello:bootstrapdeps, r=jieyouxu Update bootstrap's dependencies to remove winapi and old windows-sys Bumps `opener` to 0.8 and `junction` to 1.3 - this removes the dependency on `winapi` (unless the `build-metrics` feature is enabled) and replaces the usage of `windows-sys` 0.52 with 0.60. Together this means that bootstrap can now be built for Arm64EC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
openerto 0.8 andjunctionto 1.3 - this removes the dependency onwinapi(unless thebuild-metricsfeature is enabled) and replaces the usage ofwindows-sys0.52 with 0.60.Together this means that bootstrap can now be built for Arm64EC.