-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Unify and deduplicate algebraic float tests #146152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 1 commit into
rust-lang:master
from
rperier:unify_and_dedup_algebraic_float_tests
Sep 5, 2025
Merged
Unify and deduplicate algebraic float tests #146152
bors
merged 1 commit into
rust-lang:master
from
rperier:unify_and_dedup_algebraic_float_tests
Sep 5, 2025
+44
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Sep 3, 2025
This comment has been minimized.
This comment has been minimized.
r? tgross35
@rperier
rperier
force-pushed
the
unify_and_dedup_algebraic_float_tests
branch
from
September 3, 2025 09:08
f674d87 to
3f7584f
Compare
@rperier
rperier
force-pushed
the
unify_and_dedup_algebraic_float_tests
branch
from
September 3, 2025 12:59
3f7584f to
4e87237
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
tgross35
tgross35
approved these changes
Sep 4, 2025
LGTM, thank you!
@bors r+
@bors
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 4, 2025
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 5, 2025
...float_tests, r=tgross35 Unify and deduplicate algebraic float tests cc rust-lang#141726 This is a proposal to unify and deduplicate the algebraic tests for f16, f32, f64 and f128
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 5, 2025
...float_tests, r=tgross35 Unify and deduplicate algebraic float tests cc rust-lang#141726 This is a proposal to unify and deduplicate the algebraic tests for f16, f32, f64 and f128
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 5, 2025
...float_tests, r=tgross35 Unify and deduplicate algebraic float tests cc rust-lang#141726 This is a proposal to unify and deduplicate the algebraic tests for f16, f32, f64 and f128
bors
added a commit
that referenced
this pull request
Sep 5, 2025
Rollup of 6 pull requests Successful merges: - #144342 (add exact bitshifts) - #145709 (Fix LoongArch C function ABI when passing/returning structs containing floats) - #146152 (Unify and deduplicate algebraic float tests) - #146186 (Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools) - #146207 (std: Implement WASIp2-specific stdio routines) - #146217 (fix ICE when suggesting `::new`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 5, 2025
Rollup of 5 pull requests Successful merges: - #144342 (add exact bitshifts) - #145709 (Fix LoongArch C function ABI when passing/returning structs containing floats) - #146152 (Unify and deduplicate algebraic float tests) - #146207 (std: Implement WASIp2-specific stdio routines) - #146217 (fix ICE when suggesting `::new`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
cc #141726
This is a proposal to unify and deduplicate the algebraic tests for f16, f32, f64 and f128