-
Notifications
You must be signed in to change notification settings - Fork 13.7k
fixes auto-run js checks in tidy #146151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes auto-run js checks in tidy #146151
Conversation
tidy extra checks were modified.
Hi, I'm not aware of any .ts files (that do not come from subtrees/submodules) that we have in the repo, can you point me to them if you found some?
Hello @Kobzol. In my case, I deliberately (temporary) modified .ts files (e.g. ./src/tools/rust-analyzer/editors/code/src/lang_client.ts) under the repo, as I do not see alternatives...
Right, but the files under rust-analyzer and rustc-perf are not managed by this repository, and we thus shouldn't make any changes to them (in fact they are ignored by tidy). So until we actually have some TypeScript files in this repo, I don't think this is needed, tbh 😅
Right, but the files under rust-analyzer and rustc-perf are not managed by this repository, and we thus shouldn't make any changes to them (in fact they are ignored by tidy). So until we actually have some TypeScript files in this repo, I don't think this is needed, tbh 😅
I understand your point..
Ok, fair enough!
Thanks!
@bors r+ rollup
Modified is_non_auto_or_matches function in src/tools/tidy/src/extra_checks/mod.rs so that .ts extension is considered.
Tested locally with
./x.py test tidy --extra-checks=auto:js