-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Add amdgpu test for addrspacecasting global vars and the gpu-kernel calling convention #146148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
This PR modifies tests/auxiliary/minicore.rs.
cc @jieyouxu
This comment has been minimized.
This comment has been minimized.
Global variables are casted to the default address space works, as the amdgpu target is now merged, a test can be added.
Check that the gpu-kernel calling convention translates to `amdgpu_kernel` when compiling for the amdgpu target.
36ddcb5 to
15c6585
Compare
@bors r+
☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 2371802 to master...
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 55b9b4d (parent) -> 2371802 (this PR)
Test differences
Show 4 test diffs
Stage 1
[codegen] tests/codegen-llvm/gpu-kernel-abi.rs#amdgpu: [missing] -> pass (J0)
Stage 2
[codegen] tests/codegen-llvm/gpu-kernel-abi.rs#amdgpu: [missing] -> pass (J1)
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.
Job group index
- J0: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3
- J1: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-19-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \ test-dashboard 23718020b12d7e5a54f82a19910e8356ee719667 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
- dist-apple-various: 3608.8s -> 4827.5s (33.8%)
- dist-x86_64-apple: 6915.3s -> 8473.4s (22.5%)
- x86_64-gnu-miri: 5702.3s -> 4463.1s (-21.7%)
- aarch64-gnu-llvm-19-1: 3240.1s -> 3729.1s (15.1%)
- dist-aarch64-apple: 5646.4s -> 6302.3s (11.6%)
- aarch64-msvc-1: 7097.9s -> 6541.5s (-7.8%)
- i686-msvc-2: 7625.9s -> 8116.7s (6.4%)
- aarch64-apple: 5377.9s -> 5037.3s (-6.3%)
- x86_64-gnu-tools: 3514.2s -> 3300.2s (-6.1%)
- i686-gnu-1: 7811.6s -> 7348.7s (-5.9%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.
|
Finished benchmarking commit (2371802): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 465.905s -> 467.642s (0.37%) |
Uh oh!
There was an error while loading. Please reload this page.
Add two tests that can now be added, as the amdgpu is merged.
Tracking issue: #135024