-
Notifications
You must be signed in to change notification settings - Fork 13.7k
compiler: Apply target features to the entry function #146144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+22
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbot
rustbot
added
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Sep 3, 2025
Some changes occurred in compiler/rustc_codegen_gcc
Some changes occurred in compiler/rustc_codegen_ssa
This comment has been minimized.
This comment has been minimized.
@heiher
heiher
force-pushed
the
entry-func-features
branch
from
September 3, 2025 04:06
04f812b to
f964331
Compare
@petrochenkov
petrochenkov
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 3, 2025
@heiher
heiher
force-pushed
the
entry-func-features
branch
from
September 3, 2025 11:44
f964331 to
beb0304
Compare
bjorn3
bjorn3
reviewed
Sep 3, 2025
AirFortressIlikara
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Sep 3, 2025
Link: rust-lang/rust#146144 Signed-off-by: Ilikara <3435193369@qq.com>
@heiher
heiher
force-pushed
the
entry-func-features
branch
from
September 3, 2025 14:12
beb0304 to
7f26036
Compare
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 3, 2025
7 tasks
This comment was marked as resolved.
This comment was marked as resolved.
@heiher
heiher
force-pushed
the
entry-func-features
branch
from
September 4, 2025 07:06
7f26036 to
f028b9b
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
r=me with the nit #146144 (comment) addressed.
@rustbot author
@rustbot
rustbot
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 4, 2025
Reminder, once the PR becomes ready for a review, use @rustbot ready.
@heiher
heiher
force-pushed
the
entry-func-features
branch
from
September 4, 2025 13:57
f028b9b to
923b892
Compare
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 4, 2025
AirFortressIlikara
commented
Sep 4, 2025
We compile oma with flags below to avoid lsx:
[DEBUG]: LDFLAGS=-Wl,-O1,--sort-common,--as-needed -Wl,-build-id=sha1 -Wl,-z,relro -Wl,-z,now -fPIC -fPIE -flto -fuse-linker-plugin
[DEBUG]: CFLAGS=-pipe -Wno-error -fstack-protector-strong --param=ssp-buffer-size=4 -fexceptions -fPIC -fPIC -ggdb -O2 -fno-omit-frame-pointer -flto -mabi=lp64d -mstrict-align -march=loongarch64 -mtune=loongarch64 -msimd=none
[DEBUG]: CPPFLAGS=-D_GLIBCXX_ASSERTIONS -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3
[DEBUG]: CXXFLAGS=-ggdb -fpermissive -pipe -Wno-error -fstack-protector-strong --param=ssp-buffer-size=4 -fexceptions -fPIC -fPIC -ggdb -O2 -fno-omit-frame-pointer -flto -mabi=lp64d -mstrict-align -march=loongarch64 -mtune=loongarch64 -msimd=none
[DEBUG]: OBJCFLAGS=-pipe -Wno-error -fstack-protector-strong --param=ssp-buffer-size=4 -fexceptions -fPIC -fPIC -ggdb -O2 -fno-omit-frame-pointer -flto -mabi=lp64d -mstrict-align -march=loongarch64 -mtune=loongarch64 -msimd=none
[DEBUG]: OBJCXXFLAGS=-fpermissive -ggdb -fpermissive -pipe -Wno-error -fstack-protector-strong --param=ssp-buffer-size=4 -fexceptions -fPIC -fPIC -ggdb -O2 -fno-omit-frame-pointer -flto -mabi=lp64d -mstrict-align -march=loongarch64 -mtune=loongarch64 -msimd=none
[DEBUG]: RUSTFLAGS=-Ccodegen-units=1 -Copt-level=3 -Cdebuginfo=line-tables-only -Cforce-frame-pointers=yes -Cembed-bitcode=yes -Clinker-plugin-lto -Clinker=clang -Clink-arg=-flto -Clink-arg=-fuse-ld=lld -Clink-arg=-Wl,-build-id=sha1 -Clink-arg=-Wl,--lto-O3 -Ctarget-cpu=generic-la64 -Ctarget-feature=-lsx,+d -Clink-arg=-mabi=lp64
When using rustc 1.89.0, lsx exists
图片
Recompile rustc 1.89.0 with this patch (f028b9b) , lsx no longer exists
图片
This patch works as we expected
AirFortressIlikara
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Sep 5, 2025
Link: rust-lang/rust#146144 Signed-off-by: Ilikara <3435193369@qq.com>
@bors r+
@bors
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 5, 2025
bors
added a commit
that referenced
this pull request
Sep 5, 2025
Rollup of 11 pull requests Successful merges: - #138944 (Add `__isPlatformVersionAtLeast` and `__isOSVersionAtLeast` symbols) - #139113 (unstable book: in a sanitizer example, check the code) - #145735 (style-guide: Document absence of trailing whitespace) - #146041 (tidy: --bless now makes escheck run with --fix) - #146144 (compiler: Apply target features to the entry function) - #146225 (Simplify `{f16, f32, f64, f128}::midpoint()`) - #146234 (change file-is-generated doc comment to inner) - #146241 (rustc_infer: change top-level doc comment to inner) - #146242 (Ensure that `--html-after-content` option is used to check `scrape_examples_ice` rustdoc GUI test) - #146243 (remove couple of redundant clones) - #146250 (Bump stage0 rustfmt) Failed merges: - #146200 (Simplify rustdoc-gui tester by calling directly browser-ui-test) r? `@ghost` `@rustbot` modify labels: rollup
stydxm
pushed a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Sep 7, 2025
Link: rust-lang/rust#146144 Signed-off-by: Ilikara <3435193369@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146143