-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Implement comparison of InvisibleOrigin without PartialEq
#146090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+66
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rustbot
rustbot
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Sep 1, 2025
This comment has been minimized.
This comment has been minimized.
@Kobzol
Kobzol
force-pushed
the
invisible-origin-eq
branch
from
September 1, 2025 14:25
4ee338b to
aed6884
Compare
@petrochenkov
petrochenkov
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
For #145354, we need
PartialEqforTokenStreamto "just work". However, due to the special comparison implementation that was used forInvisibleOrigin, this wasn't the case.I found that
InvisibleOriginis stored inTokenKindandDelimitervariants. I removedPartialEqfrom them, and replaced all usages of==with an explicit comparison function. This function is probably not needed in all the cases, but I don't have enough domain knowledge to distinguish where it should be used or not.I also added a panic to the
PartialEqimpl forDelimiter, just to make sure that invisible delimiters are never compared "normally". Let's see what happens on CI.r? @petrochenkov