Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix message style for "crate-level attr used as outer attr" and "invalid custom_mir" errors #146080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scrabsha wants to merge 6 commits into rust-lang:master from scrabsha:push-lqzlpzowwlrx

Conversation

Copy link
Contributor

@scrabsha scrabsha commented Sep 1, 2025 •
edited
Loading

Mistakenly introduced by me in #145792 and #145206, reported in #145819 (comment).

On top of #145819 (comment).

@rustbot rustbot added A-attributes Area: Attributes (`#[...]`, `#![...]`) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 1, 2025
Copy link
Contributor

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2025
@scrabsha scrabsha changed the title (削除) Fix note message style for "crate-level attr used as outer attr" error (削除ここまで) (追記) Fix message style for "crate-level attr used as outer attr" and "invalid custom_mir" errors (追記ここまで) Sep 1, 2025
Copy link
Contributor Author

scrabsha commented Sep 1, 2025 •
edited
Loading

i reviewed my recent PRs and figured i did the same mistake for #[custom_mir]. this force-push fixes this as well.

Copy link
Contributor Author

scrabsha commented Sep 1, 2025 •
edited
Loading

just checked the rest of the codebase - there are several other error messages that start with a capitalized letter - i'll find them all and will open a pr over master rather rather than jana's branch.

scrabsha added a commit to scrabsha/rust that referenced this pull request Sep 2, 2025 
a more general version of rust-lang#146080.
after a bit of hacking in [`fluent.rs`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_fluent_macro/src/fluent.rs), i discovered that i'm not the only one that is bad at following guidelines 😅. this pr lowercases the first letter of all the error messages in the codebase.
(i did not change things that are traditionally uppercased such as _MIR_, _ABI_ or _C_)
i think it's reasonable to run a `@bors try` so all the test suite is checked, as i cannot run some of the tests on my machine. i double checked (and replaced manually) all the old error messages, but better be safe than sorry.
in the future i will try to add a check in `x test tidy` that errors if an error message starts with an uppercase letter.
scrabsha added a commit to scrabsha/rust that referenced this pull request Sep 3, 2025 
a more general version of rust-lang#146080.
after a bit of hacking in [`fluent.rs`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_fluent_macro/src/fluent.rs), i discovered that i'm not the only one that is bad at following guidelines 😅. this pr lowercases the first letter of all the error messages in the codebase.
(i did not change things that are traditionally uppercased such as _MIR_, _ABI_ or _C_)
i think it's reasonable to run a `@bors try` so all the test suite is checked, as i cannot run some of the tests on my machine. i double checked (and replaced manually) all the old error messages, but better be safe than sorry.
in the future i will try to add a check in `x test tidy` that errors if an error message starts with an uppercase letter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-attributes Area: Attributes (`#[...]`, `#![...]`) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /