-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Consolidate staging for compiletest steps in bootstrap #146076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Is there any RFC or blog post that describes the intended changes and goals of the whole refactoring?
Essentially this: https://blog.rust-lang.org/inside-rust/2025/05/29/redesigning-the-initial-bootstrap-sequence/. This landed ~3 months ago, and since then I'm trying to fix various bugs and issues around it.
e5a53f2 to
cc625c6
Compare
This comment has been minimized.
This comment has been minimized.
cc625c6 to
66d0607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, r=me with two comment nits
66d0607 to
6f5fc69
Compare
@bors r=jieyouxu rollup=never
Consolidate staging for compiletest steps in bootstrap This PR finishes the initial pass of refactorings that fixed up staging of various bootstrap steps after the stage0 redesign. Now the *real* refactorings can begin =D It fixes the unnecessary stage2 build of cargo for run-make tests (https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/run-make.20cargo.20staging/with/536662651), and also consolidates staging of messages printed by bootstrap for test steps (`Testing stageN...` etc.). r? `@jieyouxu`
This comment has been minimized.
This comment has been minimized.
Oh right, ui-fulldeps...
💔 Test failed - checks-actions
Hmm, I tested this before, maybe it regressed.
@bors try jobs=x86_64-gnu-llvm-20-1,x86_64-gnu-llvm-20-2,x86_64-gnu-llvm-20-3
This comment has been minimized.
This comment has been minimized.
Consolidate staging for compiletest steps in bootstrap try-job: x86_64-gnu-llvm-20-1 try-job: x86_64-gnu-llvm-20-2 try-job: x86_64-gnu-llvm-20-3
@bors r=jieyouxu
Ok that was a silly bug, I shouldn't have replaced that if condition :)
This PR finishes the initial pass of refactorings that fixed up staging of various bootstrap steps after the stage0 redesign. Now the real refactorings can begin =D
It fixes the unnecessary stage2 build of cargo for run-make tests (https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/run-make.20cargo.20staging/with/536662651), and also consolidates staging of messages printed by bootstrap for test steps (
Testing stageN...etc.).r? @jieyouxu