-
Notifications
You must be signed in to change notification settings - Fork 13.7k
changes for vxworks #146073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes for vxworks #146073
Conversation
r? @ibraheemdev
rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)
Click to see the possible cause of the failure (guessed by this bot)
##[endgroup]
[TIMING:end] tool::ToolBuild { build_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "", cargo_args: [], artifact_kind: Binary } -- 11.121
[TIMING:end] tool::Tidy { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.000
fmt check
Diff in /checkout/library/std/src/fs/tests.rs:802:
let canary = tmpdir.join("do_not_delete");
check!(check!(File::create(&canary)).write(b"foo"));
let result = fs::remove_dir_all(&canary);
- #[cfg(all(not(target_os = "vxworks"),unix))]
+ #[cfg(all(not(target_os = "vxworks"), unix))]
error!(result, "Not a directory");
#[cfg(target_os = "vxworks")]
error!(result, "not a directory");
fmt: checked 6344 files
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:00:48
local time: Mon Sep 1 05:22:38 UTC 2025
network time: 2025年9月01日 05:22:38 GMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make these look like this, with some reasoning for why this test is ignored on vxworks (is there a fundamental reason, is it just not implemented yet, etc)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cleaner as a cfg_select!, e.g.
changes for vxworks
This PR improves support for the
vxworkstarget in the Rust standard library by fixing platform-specific issues and ensuring better compatibility with VxWorks.These changes are isolated to
vxworksand do not affect other platforms
This description restates in four different ways that it improves vxworks support, but gives no indication of what it changes or why that is. Please make sure it’s easy for reviewers to understand what is going on, even "Ignore X-related tests that currently fail on VxWorks" is more useful.
Pinging target maintainer @biabbas for review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The change to the error string in concurrent recursive mkdir test is a valid change. But it is better done in the suggested way.
- Af_unix mechanism is not supported on vxworks. Hence the Unix datagram tests should be ignored. Specifying this reason in the cfg attribute as suggested would be better. Also, Don't remove the comments specified for the android selinux target.
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR improves support for the
vxworkstarget in the Rust standard library by fixing platform-specific issues and ensuring better compatibility with VxWorks.These changes are isolated to
vxworksand do not affect other platforms.Notes
Tested manually on a VxWorks environment. Feedback on potential edge cases or additional tests would be appreciated.