-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Remove incorrect fixme on deprecation target #146029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.
Some changes occurred in compiler/rustc_attr_parsing
@bors r+
@bors rollup
☀️ Test successful - checks-actions
Approved by: jdonszelmann
Pushing 523d399 to master...
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 0f50696 (parent) -> 523d399 (this PR)
Test differences
No test diffs found
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \ test-dashboard 523d3999dcd4bbd9a52661a29dbd7351a9c5fb03 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
- dist-aarch64-apple: 5773.8s -> 6735.0s (16.6%)
- dist-aarch64-msvc: 5862.5s -> 5314.6s (-9.3%)
- dist-apple-various: 3413.9s -> 3709.8s (8.7%)
- x86_64-gnu-llvm-19: 2402.4s -> 2609.2s (8.6%)
- aarch64-gnu-llvm-19-2: 2160.1s -> 2340.7s (8.4%)
- dist-x86_64-windows-gnullvm: 4730.3s -> 5097.3s (7.8%)
- aarch64-gnu-debug: 4375.3s -> 4707.8s (7.6%)
- aarch64-apple: 5051.3s -> 5428.7s (7.5%)
- dist-x86_64-illumos: 6279.3s -> 5849.1s (-6.8%)
- pr-check-1: 1384.1s -> 1464.6s (5.8%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.
|
Finished benchmarking commit (523d399): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 3.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 465.405s -> 465.403s (-0.00%) |
This does actually working suprisingly enough, applying deprecation to all methods in the impl block
r? @jdonszelmann