Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

compiler: Include span of too huge array with -Cdebuginfo=2 #146025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into rust-lang:master from Enselic:big-array-debuginfo-span
Sep 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,16 +103,17 @@ fn build_fixed_size_array_di_node<'ll, 'tcx>(
cx: &CodegenCx<'ll, 'tcx>,
unique_type_id: UniqueTypeId<'tcx>,
array_type: Ty<'tcx>,
span: Span,
) -> DINodeCreationResult<'ll> {
let ty::Array(element_type, len) = array_type.kind() else {
bug!("build_fixed_size_array_di_node() called with non-ty::Array type `{:?}`", array_type)
};

let element_type_di_node = type_di_node(cx, *element_type);
let element_type_di_node = spanned_type_di_node(cx, *element_type, span);

return_if_di_node_created_in_meantime!(cx, unique_type_id);

let (size, align) = cx.size_and_align_of(array_type);
let (size, align) = cx.spanned_size_and_align_of(array_type, span);

let upper_bound = len
.try_to_target_usize(cx.tcx)
Expand Down Expand Up @@ -447,7 +448,7 @@ pub(crate) fn spanned_type_di_node<'ll, 'tcx>(
build_basic_type_di_node(cx, t)
}
ty::Tuple(elements) if elements.is_empty() => build_basic_type_di_node(cx, t),
ty::Array(..) => build_fixed_size_array_di_node(cx, unique_type_id, t),
ty::Array(..) => build_fixed_size_array_di_node(cx, unique_type_id, t, span),
ty::Slice(_) | ty::Str => build_slice_type_di_node(cx, t, unique_type_id),
ty::Dynamic(..) => build_dyn_type_di_node(cx, t, unique_type_id),
ty::Foreign(..) => build_foreign_type_di_node(cx, t, unique_type_id),
Expand Down
7 changes: 6 additions & 1 deletion compiler/rustc_codegen_llvm/src/type_of.rs
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ use rustc_middle::bug;
use rustc_middle::ty::layout::{LayoutOf, TyAndLayout};
use rustc_middle::ty::print::{with_no_trimmed_paths, with_no_visible_paths};
use rustc_middle::ty::{self, CoroutineArgsExt, Ty, TypeVisitableExt};
use rustc_span::{DUMMY_SP, Span};
use tracing::debug;

use crate::common::*;
Expand Down Expand Up @@ -149,7 +150,11 @@ impl<'a, 'tcx> CodegenCx<'a, 'tcx> {
}

pub(crate) fn size_and_align_of(&self, ty: Ty<'tcx>) -> (Size, Align) {
let layout = self.layout_of(ty);
self.spanned_size_and_align_of(ty, DUMMY_SP)
}

pub(crate) fn spanned_size_and_align_of(&self, ty: Ty<'tcx>, span: Span) -> (Size, Align) {
let layout = self.spanned_layout_of(ty, span);
(layout.size, layout.align.abi)
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: values of the type `[u8; 2305843011361177600]` are too big for the target architecture
--> $DIR/huge-array-simple-64.rs:7:9
--> $DIR/huge-array-simple-64.rs:12:9
|
LL | let _fat: [u8; (1<<61)+(1<<31)] =
| ^^^^
Expand Down
8 changes: 8 additions & 0 deletions tests/ui/limits/huge-array-simple-64.no-debuginfo.stderr
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
error: values of the type `[u8; 2305843011361177600]` are too big for the target architecture
--> $DIR/huge-array-simple-64.rs:12:9
|
LL | let _fat: [u8; (1<<61)+(1<<31)] =
| ^^^^

error: aborting due to 1 previous error

5 changes: 5 additions & 0 deletions tests/ui/limits/huge-array-simple-64.rs
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
// FIXME(#61117): Remove revisions once x86_64-gnu-debug CI job sets rust.debuginfo-level-tests=2
// NOTE: The .stderr for both revisions shall be identical.
//@ revisions: no-debuginfo full-debuginfo
//@[no-debuginfo] compile-flags: -Cdebuginfo=0
//@[full-debuginfo] compile-flags: -Cdebuginfo=2
//@ build-fail
//@ ignore-32bit

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: values of the type `[[u8; 1518599999]; 1518600000]` are too big for the target architecture
--> $DIR/huge-array.rs:4:9
--> $DIR/huge-array.rs:9:9
|
LL | let s: [T; 1518600000] = [t; 1518600000];
| ^
Expand Down
8 changes: 8 additions & 0 deletions tests/ui/limits/huge-array.no-debuginfo.stderr
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
error: values of the type `[[u8; 1518599999]; 1518600000]` are too big for the target architecture
--> $DIR/huge-array.rs:9:9
|
LL | let s: [T; 1518600000] = [t; 1518600000];
| ^

error: aborting due to 1 previous error

5 changes: 5 additions & 0 deletions tests/ui/limits/huge-array.rs
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
// FIXME(#61117): Remove revisions once x86_64-gnu-debug CI job sets rust.debuginfo-level-tests=2
// NOTE: The .stderr for both revisions shall be identical.
//@ revisions: no-debuginfo full-debuginfo
//@[no-debuginfo] compile-flags: -Cdebuginfo=0
//@[full-debuginfo] compile-flags: -Cdebuginfo=2
//@ build-fail

fn generic<T: Copy>(t: T) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: values of the type `[usize; usize::MAX]` are too big for the target architecture
--> $DIR/issue-15919-64.rs:5:9
--> $DIR/issue-15919-64.rs:10:9
|
LL | let x = [0usize; 0xffff_ffff_ffff_ffff];
| ^
Expand Down
8 changes: 8 additions & 0 deletions tests/ui/limits/issue-15919-64.no-debuginfo.stderr
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
error: values of the type `[usize; usize::MAX]` are too big for the target architecture
--> $DIR/issue-15919-64.rs:10:9
|
LL | let x = [0usize; 0xffff_ffff_ffff_ffff];
| ^

error: aborting due to 1 previous error

5 changes: 5 additions & 0 deletions tests/ui/limits/issue-15919-64.rs
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
// FIXME(#61117): Remove revisions once x86_64-gnu-debug CI job sets rust.debuginfo-level-tests=2
// NOTE: The .stderr for both revisions shall be identical.
//@ revisions: no-debuginfo full-debuginfo
//@[no-debuginfo] compile-flags: -Cdebuginfo=0
//@[full-debuginfo] compile-flags: -Cdebuginfo=2
//@ build-fail
//@ ignore-32bit

Expand Down
Loading

AltStyle によって変換されたページ (->オリジナル) /