-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Add From impls for wrapper types
#146013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add From impls for wrapper types
#146013
Conversation
- `From<T> for ThinBox<T>` - `From<T> for UniqueRc<T>` - `From<T> for UniqueArc<T>` - `From<T> for ManuallyDrop<T>` - `From<T> for AssertUnwindSafe<T>`
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbot label +needs-crater
Error: Label needs-crater can only be set by Rust team members
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.
This comment has been minimized.
This comment has been minimized.
@bors try
This comment has been minimized.
This comment has been minimized.
Add `From` impls for wrapper types
@craterbot check
👌 Experiment pr-146013 created and queued.
🤖 Automatically detected try build 804fff1
🔍 You can check out the queue and this experiment's details.
i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
🚧 Experiment pr-146013 is now running
i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
🎉 Experiment pr-146013 is completed!
📊 1312 regressed and 1466 fixed (691117 total)
📊 2007 spurious results on the retry-regessed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.
i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
Footnotes
-
re-run the experiment with
crates=https://crater-reports.s3.amazonaws.com/pr-146013/retry-regressed-list.txt↩
I haven't been able to review all the regressions yet. But from the few I spot-checked: most are spurious (filesystem errors), but a few are not. All the real regressions I saw were due to the ManuallyDrop impl. And, upon reflection, that one as well as the AssertUnwindSafe impl seem dubious, so I removed the former and restricted the latter.
Uh oh!
There was an error while loading. Please reload this page.
From<T: UnwindSafe> for AssertUnwindSafe<T>From<T> for LazyCell<T, F>From<T> for LazyLock<T, F>From<T> for ThinBox<T>(unstable)From<T> for UniqueRc<T>(unstable)From<T> for UniqueArc<T>(unstable)@rustbot label T-libs-api needs-fcp
Also needs a crater run, as the insta-stable impls are technically breaking changes.