-
Notifications
You must be signed in to change notification settings - Fork 13.7k
rustdoc: render attributes in Field and Variants sections #145812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: render attributes in Field and Variants sections #145812
Conversation
Thanks!
@bors r+ rollup
☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 3776358 to master...
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 41a79f1 (parent) -> 3776358 (this PR)
Test differences
Show 2 test diffs
2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \ test-dashboard 3776358beb5747d938bdefaf47a1c76723e6a372 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
- dist-x86_64-apple: 8097.7s -> 6082.1s (-24.9%)
- dist-x86_64-freebsd: 4915.5s -> 6041.5s (22.9%)
- dist-apple-various: 5897.5s -> 4593.0s (-22.1%)
- dist-loongarch64-linux: 7049.7s -> 6081.2s (-13.7%)
- aarch64-gnu: 7275.4s -> 6702.1s (-7.9%)
- aarch64-msvc-1: 6931.5s -> 7438.1s (7.3%)
- dist-ohos-armv7: 3925.0s -> 4165.9s (6.1%)
- dist-aarch64-msvc: 5776.5s -> 5427.8s (-6.0%)
- dist-various-2: 3331.4s -> 3135.6s (-5.9%)
- aarch64-gnu-llvm-19-1: 3607.4s -> 3400.3s (-5.7%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.
|
Finished benchmarking commit (3776358): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 6.6%, secondary 2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 468.201s -> 467.391s (-0.17%) |
Uh oh!
There was an error while loading. Please reload this page.
Follow up to #145782.
Render attributes in Field and Variants sections.
Associated constants and methods are already rendered with attributes in their sections, so I figured out fields and variants should too.
(no change here)
image
r? @GuillaumeGomez
Before (left) / after (right):
image image image image image image