-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Check for bound variables when reporting type error #145757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthewjasper
wants to merge
1
commit into
rust-lang:master
from
matthewjasper:type-mismatch-bound-vars
Open
Check for bound variables when reporting type error #145757
matthewjasper
wants to merge
1
commit into
rust-lang:master
from
matthewjasper:type-mismatch-bound-vars
+69
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @davidtwco
rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r?
to explicitly pick a reviewer
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Aug 22, 2025
compiler-errors
compiler-errors
requested changes
Aug 23, 2025
compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs
Outdated
Show resolved
Hide resolved
@jieyouxu
jieyouxu
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 25, 2025
`can_eq` ICEs if it's passed types with escaping bound variables, so we need to handle for them, even in error reporting.
@matthewjasper
matthewjasper
force-pushed
the
type-mismatch-bound-vars
branch
from
August 25, 2025 09:20
e1570fe
to
608d49a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
can_eq
inpoint_at_chain
ICEs if it's passed types with escaping bound variables, so we need to check for them, even in error reporting. Since this is just for error reporting simply skip types with escaping bound variables.closes #145631