-
Notifications
You must be signed in to change notification settings - Fork 13.7k
add Iterator::dedup and friends #145733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Iterator::dedup and friends #145733
Conversation
r? @ibraheemdev
rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r?
to explicitly pick a reviewer
This comment has been minimized.
This comment has been minimized.
1b0c56c
to
dc17002
Compare
Some changes occurred in compiler/rustc_codegen_ssa
r? libs-api
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dc17002
to
6308a8a
Compare
Some changes occurred in src/tools/clippy
cc @rust-lang/clippy
The job pr-check-1
failed! Check out the build log: (web) (plain enhanced) (plain)
Click to see the possible cause of the failure (guessed by this bot)
= note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
= help: call with fully qualified syntax `itertools::Itertools::dedup(...)` to keep using the current method
= note: `-D unstable-name-collisions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unstable_name_collisions)]`
help: add `#![feature(iter_dedup)]` to the crate attributes to enable `std::iter::Iterator::dedup`
--> src/tools/rust-analyzer/crates/hir-def/src/lib.rs:12:1
|
12 + #![feature(iter_dedup)]
|
error: a method with this name may be added to the standard library in the future
--> src/tools/rust-analyzer/crates/hir-def/src/item_scope.rs:258:14
|
258 | .dedup()
| ^^^^^
|
= warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
= note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
= help: call with fully qualified syntax `itertools::Itertools::dedup(...)` to keep using the current method
help: add `#![feature(iter_dedup)]` to the crate attributes to enable `std::iter::Iterator::dedup`
--> src/tools/rust-analyzer/crates/hir-def/src/lib.rs:12:1
|
12 + #![feature(iter_dedup)]
|
[RUSTC-TIMING] serde_json test:false 2.334
Checking icu_locale_core v2.0.0
[RUSTC-TIMING] chalk_solve test:false 5.378
---
Checking icu_normalizer v2.0.0
error: a method with this name may be added to the standard library in the future
--> src/tools/rust-analyzer/crates/hir-def/src/nameres/collector.rs:2216:14
|
2216 | .dedup_by(|a, b| {
| ^^^^^^^^
|
= warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
= note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
= help: call with fully qualified syntax `itertools::Itertools::dedup_by(...)` to keep using the current method
help: add `#![feature(iter_dedup)]` to the crate attributes to enable `std::iter::Iterator::dedup_by`
--> src/tools/rust-analyzer/crates/hir-def/src/lib.rs:12:1
|
12 + #![feature(iter_dedup)]
|
[RUSTC-TIMING] yoke test:false 0.337
Checking icu_properties v2.0.1
error: a method with this name may be added to the standard library in the future
--> src/tools/rust-analyzer/crates/hir-def/src/import_map.rs:104:14
|
104 | .dedup_by(|&(_, (_, lhs, _)), &(_, (_, rhs, _))| lhs.eq_ignore_ascii_case(rhs));
| ^^^^^^^^
|
= warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
= note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
= help: call with fully qualified syntax `itertools::Itertools::dedup_by(...)` to keep using the current method
help: add `#![feature(iter_dedup)]` to the crate attributes to enable `std::iter::Iterator::dedup_by`
--> src/tools/rust-analyzer/crates/hir-def/src/lib.rs:12:1
|
12 + #![feature(iter_dedup)]
|
[RUSTC-TIMING] windows_sys test:false 7.628
Checking line-index v0.1.2
[RUSTC-TIMING] line_index test:false 0.247
Uh oh!
There was an error while loading. Please reload this page.
Tracking issue: #83747