Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add Iterator::dedup and friends #145733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Qelxiros wants to merge 1 commit into rust-lang:master
base: master
Choose a base branch
Loading
from Qelxiros:iter-dedup

Conversation

Copy link
Contributor

@Qelxiros Qelxiros commented Aug 22, 2025
edited by rustbot
Loading

Tracking issue: #83747

Luracasmus reacted with eyes emoji
Copy link
Collaborator

rustbot commented Aug 22, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 22, 2025

This comment has been minimized.

Copy link
Collaborator

rustbot commented Aug 22, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Copy link
Member

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 22, 2025
@rustbot rustbot assigned dtolnay and unassigned ibraheemdev Aug 22, 2025

This comment has been minimized.

Copy link
Member

@dtolnay dtolnay left a comment
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I expect that this is going to be blocked on compiler work (#89151) for the same reason as this other pending Iterator method: #141994.

View changes since this review

@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Aug 22, 2025
Copy link
Collaborator

rustbot commented Aug 22, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Copy link
Collaborator

The job pr-check-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
 = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
 = help: call with fully qualified syntax `itertools::Itertools::dedup(...)` to keep using the current method
 = note: `-D unstable-name-collisions` implied by `-D warnings`
 = help: to override `-D warnings` add `#[allow(unstable_name_collisions)]`
help: add `#![feature(iter_dedup)]` to the crate attributes to enable `std::iter::Iterator::dedup`
 --> src/tools/rust-analyzer/crates/hir-def/src/lib.rs:12:1
 |
 12 + #![feature(iter_dedup)]
 |
error: a method with this name may be added to the standard library in the future
 --> src/tools/rust-analyzer/crates/hir-def/src/item_scope.rs:258:14
 |
258 | .dedup()
 | ^^^^^
 |
 = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
 = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
 = help: call with fully qualified syntax `itertools::Itertools::dedup(...)` to keep using the current method
help: add `#![feature(iter_dedup)]` to the crate attributes to enable `std::iter::Iterator::dedup`
 --> src/tools/rust-analyzer/crates/hir-def/src/lib.rs:12:1
 |
 12 + #![feature(iter_dedup)]
 |
[RUSTC-TIMING] serde_json test:false 2.334
 Checking icu_locale_core v2.0.0
[RUSTC-TIMING] chalk_solve test:false 5.378
---
 Checking icu_normalizer v2.0.0
error: a method with this name may be added to the standard library in the future
 --> src/tools/rust-analyzer/crates/hir-def/src/nameres/collector.rs:2216:14
 |
2216 | .dedup_by(|a, b| {
 | ^^^^^^^^
 |
 = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
 = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
 = help: call with fully qualified syntax `itertools::Itertools::dedup_by(...)` to keep using the current method
help: add `#![feature(iter_dedup)]` to the crate attributes to enable `std::iter::Iterator::dedup_by`
 --> src/tools/rust-analyzer/crates/hir-def/src/lib.rs:12:1
 |
 12 + #![feature(iter_dedup)]
 |
[RUSTC-TIMING] yoke test:false 0.337
 Checking icu_properties v2.0.1
error: a method with this name may be added to the standard library in the future
 --> src/tools/rust-analyzer/crates/hir-def/src/import_map.rs:104:14
 |
104 | .dedup_by(|&(_, (_, lhs, _)), &(_, (_, rhs, _))| lhs.eq_ignore_ascii_case(rhs));
 | ^^^^^^^^
 |
 = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
 = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
 = help: call with fully qualified syntax `itertools::Itertools::dedup_by(...)` to keep using the current method
help: add `#![feature(iter_dedup)]` to the crate attributes to enable `std::iter::Iterator::dedup_by`
 --> src/tools/rust-analyzer/crates/hir-def/src/lib.rs:12:1
 |
 12 + #![feature(iter_dedup)]
 |
[RUSTC-TIMING] windows_sys test:false 7.628
 Checking line-index v0.1.2
[RUSTC-TIMING] line_index test:false 0.247

@dtolnay dtolnay added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2025
Copy link
Contributor Author

@dtolnay That's my expectation as well. Should I continue to fix the failing checks, or will that work become obsolete when #89151 is resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-clippy Relevant to the Clippy team. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /