-
Notifications
You must be signed in to change notification settings - Fork 13.7k
compiletest: Require explicit --filecheck-prefixes
#145428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rustbot
rustbot
added
A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Aug 15, 2025
@rustbot
rustbot
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 15, 2025
@tgross35
tgross35
added
the
rla-silenced
Silences rust-log-analyzer postings to the PR it's added on.
label
Aug 15, 2025
@tgross35
tgross35
force-pushed
the
less-filecheck-magic
branch
2 times, most recently
from
August 15, 2025 20:55
59c64d4 to
11ae4d5
Compare
@tgross35
tgross35
force-pushed
the
less-filecheck-magic
branch
from
August 15, 2025 21:47
11ae4d5 to
3fa9db2
Compare
@bors2 try
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 15, 2025
compiletest: Require explicit `--filecheck-prefixes` try-job: aarch64-apple try-job: i686-gnu-* try-job: test-various try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
The job test-various failed! Check out the build log: (web) (plain enhanced) (plain)
Click to see the possible cause of the failure (guessed by this bot)
failures:
---- [codegen] tests/codegen-llvm/codemodels.rs#MODEL-KERNEL stdout ----
error in revision `MODEL-KERNEL`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/codemodels.MODEL-KERNEL/codemodels.ll" "/checkout/tests/codegen-llvm/codemodels.rs" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'CHECK:'
------------------------------------------
---- [codegen] tests/codegen-llvm/codemodels.rs#MODEL-LARGE stdout ----
error in revision `MODEL-LARGE`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/codemodels.MODEL-LARGE/codemodels.ll" "/checkout/tests/codegen-llvm/codemodels.rs" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'CHECK:'
------------------------------------------
---- [codegen] tests/codegen-llvm/codemodels.rs#MODEL-MEDIUM stdout ----
error in revision `MODEL-MEDIUM`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/codemodels.MODEL-MEDIUM/codemodels.ll" "/checkout/tests/codegen-llvm/codemodels.rs" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'CHECK:'
------------------------------------------
---- [codegen] tests/codegen-llvm/codemodels.rs#MODEL-SMALL stdout ----
error in revision `MODEL-SMALL`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/codemodels.MODEL-SMALL/codemodels.ll" "/checkout/tests/codegen-llvm/codemodels.rs" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'CHECK:'
------------------------------------------
---- [codegen] tests/codegen-llvm/codemodels.rs#NOMODEL stdout ----
error in revision `NOMODEL`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/codemodels.NOMODEL/codemodels.ll" "/checkout/tests/codegen-llvm/codemodels.rs" "--dump-input-context" "100"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'CHECK:'
------------------------------------------
---- [codegen] tests/codegen-llvm/simd/packed-simd.rs#opt3 stdout ----
error in revision `opt3`: verification with 'FileCheck' failed
status: exit status: 2
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-llvm/simd/packed-simd.opt3/packed-simd.ll" "/checkout/tests/codegen-llvm/simd/packed-simd.rs" "--dump-input-context" "100" "--check-prefixes=CHECK,opt3"
stdout: none
--- stderr -------------------------------
error: no check strings found with prefix 'opt3:'
------------------------------------------
💔 Test for 37206fb failed: CI. Failed jobs:
try - aarch64-apple(web logs, extended logs)try - i686-gnu-1(web logs, extended logs)try - i686-gnu-2(web logs, extended logs)try - i686-gnu-nopt-1(web logs, extended logs)- (and 4 other jobs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes: #134510
r? @ghost
try-job: aarch64-apple
try-job: i686-gnu-*
try-job: test-various
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2