Switch Instant to use CLOCK_BOOTTIME on Android. #145360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jfgoog wants to merge 1 commit into rust-lang:master from jfgoog:android-time

Closed

Switch Instant to use CLOCK_BOOTTIME on Android. #145360

jfgoog wants to merge 1 commit into rust-lang:master from jfgoog:android-time

+6 −1

Conversation

jfgoog

Copy link

Contributor

@jfgoog jfgoog commented Aug 13, 2025

This is a long-term patch we have carried for the Android platform:

https://android.googlesource.com/toolchain/android_rust/+/refs/heads/main/patches/longterm/rustc-0018-Switch-Instant-to-use-CLOCK_BOOTTIME.patch

@jfgoog


 Switch Instant to use CLOCK_BOOTTIME on Android.

ab8dfd9

This is a long-term patch we have carried for the Android platform:
https://android.googlesource.com/toolchain/android_rust/+/refs/heads/main/patches/longterm/rustc-0018-Switch-Instant-to-use-CLOCK_BOOTTIME.patch

@rustbot rustbot assigned thomcc

Aug 13, 2025

@rustbot

Copy link

Collaborator

rustbot commented Aug 13, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix S-waiting-on-review T-libs labels

Aug 13, 2025

@the8472

Copy link

Member

the8472 commented Aug 13, 2025 •

edited

Loading

Near-duplicate of #132331 (esp. #132331 (comment))
See also:

And personally I think android shouldn't be carrying this patch, since it indicates you have broken code somewhere else that relies on explicitly disclaimed behavior.

@tgross35

Copy link

Contributor

tgross35 commented Sep 3, 2025

Closing because as @the8472 mentioned, this was discussed in #132331 (comment) and the plan is to introduce an alternative clock that has the needed guarantees.