-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Access less HIR attributes from typeck #144841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try @rust-timer queue
This comment has been minimized.
This comment has been minimized.
Access less HIR attributes from typeck
This comment has been minimized.
This comment has been minimized.
💔 Test failed (CI). Failed jobs:
bors build finished(web logs, extended logs)try - dist-x86_64-linux(web logs, extended logs)
This comment has been minimized.
This comment has been minimized.
d414182 to
bf644e9
Compare
@bors try @rust-timer queue
This comment has been minimized.
This comment has been minimized.
Access less HIR attributes from typeck
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (038c022): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.5%, secondary 4.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 467.629s -> 467.286s (-0.07%) |
@bors try @rust-timer queue
This comment has been minimized.
This comment has been minimized.
❌ Encountered an error while executing command
@bors try @rust-timer queue
This comment has been minimized.
This comment has been minimized.
Access less HIR attributes from typeck
|
Finished benchmarking commit (f6975aa): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.8%, secondary 0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -5.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 466.337s -> 468.162s (0.39%) |
r? @SparrowLii
rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.
r? compiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending one review comment
@bors r+
☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 269d5b5 to master...
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 176d8db (parent) -> 269d5b5 (this PR)
Test differences
Show 12 test diffs
Stage 1
[crashes] tests/crashes/124352.rs: pass -> [missing] (J0)[ui] tests/ui/attributes/malformed-never-type-options.rs: [missing] -> pass (J0)
Stage 2
[crashes] tests/crashes/124352.rs: pass -> [missing] (J1)[ui] tests/ui/attributes/malformed-never-type-options.rs: [missing] -> pass (J2)
Additionally, 8 doctest diffs were found. These are ignored, as they are noisy.
Job group index
- J0: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3
- J1: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-19-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
- J2: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-19-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-llvm-19, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \ test-dashboard 269d5b56bcfdf2be82213e72ef9a2e4c592a8c6b --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
- pr-check-1: 1723.9s -> 1407.0s (-18.4%)
- dist-apple-various: 4532.6s -> 5205.0s (14.8%)
- dist-x86_64-apple: 6948.0s -> 7816.0s (12.5%)
- dist-aarch64-msvc: 5667.1s -> 6354.8s (12.1%)
- aarch64-apple: 5761.7s -> 5139.6s (-10.8%)
- i686-gnu-2: 5689.1s -> 6221.7s (9.4%)
- x86_64-gnu-aux: 6347.9s -> 6755.3s (6.4%)
- aarch64-msvc-1: 6397.1s -> 6773.0s (5.9%)
- aarch64-gnu-llvm-19-1: 3585.8s -> 3780.8s (5.4%)
- x86_64-rust-for-linux: 3032.7s -> 2868.8s (-5.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.
Access less HIR attributes from typeck Typeck relies on attributes to modify its own behaviour. This is a problem, as this means that `typeck(some function)` may depend on the span and doc-comments of many other functions. This PR attempts to reduce such accesses to attributes. This yields to a sizeable perf improvement: rust-lang/rust#144841 (comment) Fixes rust-lang/rust#124352
|
Finished benchmarking commit (269d5b5): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.1%, secondary 4.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -4.1%, secondary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 467.709s -> 466.752s (-0.20%) |
Access less HIR attributes from typeck Typeck relies on attributes to modify its own behaviour. This is a problem, as this means that `typeck(some function)` may depend on the span and doc-comments of many other functions. This PR attempts to reduce such accesses to attributes. This yields to a sizeable perf improvement: rust-lang/rust#144841 (comment) Fixes rust-lang/rust#124352
More improvements than regressions, and a very nice incremental win on nalgebra.
@rustbot label: +perf-regression-triaged
Uh oh!
There was an error while loading. Please reload this page.
Typeck relies on attributes to modify its own behaviour. This is a problem, as this means that
typeck(some function)may depend on the span and doc-comments of many other functions.This PR attempts to reduce such accesses to attributes. This yields to a sizeable perf improvement: #144841 (comment)
Fixes #124352