Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Start reporting future breakage for ILL_FORMED_ATTRIBUTE_INPUT in dependencies #144544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into rust-lang:master from JonathanBrouwer:illformed-in-deps
Aug 10, 2025

Conversation

Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Jul 27, 2025 •
edited
Loading

This has been a warn lint since early 2019 and a deny-by-default lint since late 2019.
We're currently transitioning some of the cases where this lint is being produced to a hard error (#143607 #143808 and more)
So let's report this lint in all dependencies for the remaining attributes

r? @traviscross
@rustbot labels +I-lang-nominated +T-lang -T-compiler
cc @jdonszelmann

(Separate question: Why does the "Future incompatibility report" only trigger if report_in_deps is true, even if the future incompatibility happens in the same crate, is this correct?)

This also needs a crater run, but I don't have permissions to trigger this

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. I-lang-nominated Nominated for discussion during a lang team meeting. T-lang Relevant to the language team and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 27, 2025
Copy link
Member

Urgau commented Jul 27, 2025

@bors2 try

Copy link

rust-bors bot commented Jul 27, 2025

⌛ Trying commit 7bd902d with merge d7b15db...

To cancel the try build, run the command @bors try cancel.

rust-bors bot added a commit that referenced this pull request Jul 27, 2025 
Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies
Copy link

rust-bors bot commented Jul 27, 2025

☀️ Try build successful (CI)
Build commit: d7b15db (d7b15db413fd2070daa09a2c5b7f2ab38417429f, parent: 4b596bbd847672da87763b76171687d3544863c2)

@traviscross traviscross added the P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang label Jul 28, 2025
Copy link
Contributor

cc @rust-lang/lang @rust-lang/lang-advisors

Copy link
Contributor

It seems clear to me that we should do this in any event, so let's...

@rfcbot fcp merge

Copy link

rfcbot commented Jul 28, 2025 •
edited by scottmcm
Loading

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 28, 2025
Copy link
Contributor

@bors try

rust-bors bot added a commit that referenced this pull request Jul 28, 2025 
Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies
Copy link

rust-bors bot commented Jul 28, 2025

⌛ Trying commit 7bd902d with merge b19a6f8...

To cancel the try build, run the command @bors try cancel.

Copy link
Contributor

@craterbot check

Copy link
Collaborator

👌 Experiment pr-144544 created and queued.
🤖 Automatically detected try build d7b15db
🔍 You can check out the queue and this experiment's details.

i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2025
Copy link
Contributor

@bors try cancel

Copy link

rust-bors bot commented Jul 28, 2025

Try build cancelled. Cancelled workflows:

Copy link
Collaborator

🚧 Experiment pr-144544 is now running

i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Copy link
Collaborator

🎉 Experiment pr-144544 is completed!
📊 3 regressed and 7 fixed (672551 total)
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 29, 2025
Copy link
Contributor Author

All 3 regressions seem spurious

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025 
... r=traviscross
Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies
This has been a warn lint since early 2019 and a deny-by-default lint since late 2019.
We're currently transitioning some of the cases where this lint is being produced to a hard error (rust-lang#143607 rust-lang#143808 and more)
So let's report this lint in all dependencies for the remaining attributes
r? ````@traviscross````
````@rustbot```` labels +I-lang-nominated +T-lang -T-compiler
cc ````@jdonszelmann````
(Separate question: Why does the "Future incompatibility report" only trigger if `report_in_deps` is true, even if the future incompatibility happens in the same crate, is this correct?)
This also needs a crater run, but I don't have permissions to trigger this
bors added a commit that referenced this pull request Aug 10, 2025 
Rollup of 19 pull requests
Successful merges:
 - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
 - #143093 (Simplify polonius location-sensitive analysis)
 - #144402 (Stabilize loongarch32 inline asm)
 - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
 - #144544 (Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies)
 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
 - #145130 (improve "Documentation problem" issue template.)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145145 (some `derive_more` refactors)
 - #145147 (rename `TraitRef::from_method` to `from_assoc`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])
 - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
 - #145175 (Enable limit_rdylib_exports on Solaris)
 - #145187 (Fix an unstable feature comment that wasn't a doc comment)
 - #145191 (`suggest_borrow_generic_arg`: use the correct generic args)
r? `@ghost`
`@rustbot` modify labels: rollup
Copy link
Member

jieyouxu commented Aug 10, 2025 •
edited
Loading

Seems to have failed rollup #145197 (comment) 

662 For more information about an error, try `rustc --explain E0308`.
663 Future incompatibility report: Future breakage diagnostic:
664 error: valid forms for the attribute are `#[doc(hidden|inline|...)]` and `#[doc = "string"]`
- --> $DIR/malformed-attrs.rs:44:1
+ --> $DIR/malformed-attrs.rs:40:1
666 |
667 LL | #[doc]
668 | ^^^^^^

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 10, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 10, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2025
@jieyouxu jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2025

This comment has been minimized. 

...ependencies
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Copy link
Contributor Author

JonathanBrouwer commented Aug 10, 2025 •
edited
Loading

Was able to reproduce locally, fixed & rebased.
Because of the line numbers in the "Future incompatibility report", this is PR is likely to soft-conflict.
Don't rollup with any attribute-related PRs

Copy link
Member

@bors rollup=never (conflicts with attribute-related PRs)

Copy link
Contributor

@bors r+ rollup=never

Copy link
Collaborator

bors commented Aug 10, 2025

📌 Commit b2b4bd4 has been approved by traviscross

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 10, 2025
Copy link
Collaborator

bors commented Aug 10, 2025

⌛ Testing commit b2b4bd4 with merge 29737cb...

Copy link
Collaborator

bors commented Aug 10, 2025

☀️ Test successful - checks-actions
Approved by: traviscross
Pushing 29737cb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 10, 2025
@bors bors merged commit 29737cb into rust-lang:master Aug 10, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 10, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 18eeac0 (parent) -> 29737cb (this PR)

Test differences

Show 276 test diffs

276 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
 test-dashboard 29737cb44beb67dbcf001ca1f11b7ec8964d8d06 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-1: 11621.6s -> 8080.9s (-30.5%)
  2. dist-x86_64-apple: 8100.6s -> 9227.9s (13.9%)
  3. aarch64-gnu-llvm-19-1: 4089.2s -> 3616.1s (-11.6%)
  4. test-various: 4607.2s -> 5087.6s (10.4%)
  5. x86_64-apple-2: 5165.4s -> 5631.9s (9.0%)
  6. aarch64-apple: 5492.7s -> 5970.2s (8.7%)
  7. x86_64-gnu-llvm-19-1: 3330.2s -> 3619.0s (8.7%)
  8. dist-aarch64-apple: 5909.6s -> 5490.8s (-7.1%)
  9. dist-various-2: 3165.0s -> 2948.5s (-6.8%)
  10. aarch64-gnu: 7075.5s -> 7538.3s (6.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Copy link
Collaborator

Finished benchmarking commit (29737cb): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.1% [0.1%, 0.2%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.0% [-0.1%, -0.0%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 4.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.6% [4.5%, 4.6%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary 2.3%, secondary -4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)		 3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.6% [-7.6%, -5.9%] 3
All ❌✅ (primary) 2.3% [2.3%, 2.3%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 462.481s -> 464.526s (0.44%)
Artifact size: 377.60 MiB -> 377.35 MiB (-0.07%)

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /