Don't repeatedly access recursion limit #144474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

compiler-errors wants to merge 1 commit into rust-lang:master from compiler-errors:recur-limit

Closed

Don't repeatedly access recursion limit #144474

compiler-errors wants to merge 1 commit into rust-lang:master from compiler-errors:recur-limit

Conversation

compiler-errors

Copy link

Member

@compiler-errors compiler-errors commented Jul 26, 2025

This is a microoptimization. Probably not worth it, but let's see.

@compiler-errors


 Don't repeatedly access recursion limit

@rustbot rustbot assigned petrochenkov

Jul 26, 2025

@rustbot

Copy link

Collaborator

rustbot commented Jul 26, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review T-compiler WG-trait-system-refactor labels

Jul 26, 2025

@rustbot

Copy link

Collaborator

rustbot commented Jul 26, 2025

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@compiler-errors

Copy link

Member Author

compiler-errors commented Jul 26, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request

Jul 26, 2025

@rust-bors


 Auto merge of #144474 - compiler-errors:recur-limit, r=<try>

9011ac9

Don't repeatedly access recursion limit

@rust-bors

Copy link

rust-bors bot commented Jul 26, 2025

⌛ Trying commit 4410204 with merge 9011ac9...

To cancel the try build, run the command @bors try cancel.

@rustbot rustbot added the S-waiting-on-perf label

Jul 26, 2025

@compiler-errors compiler-errors assigned lcnr and unassigned petrochenkov

Jul 26, 2025

@rust-bors

Copy link

rust-bors bot commented Jul 26, 2025

☀️ Try build successful (CI)
Build commit: 9011ac9 (9011ac952f72633e43b9b442c6ade02b4ff833ab, parent: 430d6eddfc6a455ca4a0137c0822a982cccd3b2b)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link

Collaborator

rust-timer commented Jul 26, 2025

Finished benchmarking commit (9011ac9): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -5.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.4%	[-7.4%, -3.4%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.9%	[-3.9%, -3.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.9%	[-3.9%, -3.9%]	1