-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Reoganize poison::rwlock
file
#144175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Reoganize poison::rwlock
file
#144175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r?
to explicitly pick a reviewer
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jul 19, 2025
@connortsui20
connortsui20
changed the title
(削除) Reoganize rwlock file (削除ここまで)
(追記) Reoganize Jul 19, 2025
poison::rwlock
file (追記ここまで)
@connortsui20
connortsui20
force-pushed
the
rwlock-cleanup
branch
from
July 19, 2025 11:02
f48b596
to
5f9c9eb
Compare
This commit reorganizes the `rwlock` tests, moving the tests that involve poisoning away from the ones that do not.
@connortsui20
connortsui20
force-pushed
the
rwlock-cleanup
branch
from
July 21, 2025 12:16
5f9c9eb
to
1c6bc6e
Compare
Closing this in favor of integrating this directly into the PR that implements #[feature(nonpoison_rwlock)]
(coming soon)
@rustbot
rustbot
removed
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR is a purely cosmetic change to the documentation and ordering of items in the
rwlock.rs
file.This is mainly in preparation for the eventual implementation of
#![feature(nonpoison_rwlock)]
(which I am planning to do soon), and the issue for that can be found in #134645. These changes should make it easier to find things in the code and port things over to a futurenonpoison
variant ofRwLock
.List of changes (lots of small things):
'rwlock
instead of'a
ReadGuard
,WriteGuard
,MappedReadGuard
,MappedWriteGuard
)poison
field inMappedRwLockWriteGuard
toposion_guard
downgrade
to match Stabilizerwlock_downgrade
library feature #143191Edit: some more cosmetic changes to the
rwlock
test file, and it is simply moving tests up or down depending on if they test poisoning or not. This will again make the implementation ofnonpoison_rwlock
much easier.