-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Do not lint private-in-public for RPITIT #144098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jul 17, 2025
@cjgillot
cjgillot
force-pushed
the
lint-rpitit
branch
from
July 17, 2025 23:59
17a1586 to
c004a96
Compare
This was referenced Jul 18, 2025
If the behaviour is actually desirable, the second commit can be reverted with a proper crater run.
Yes, it is actually desirable, and #143357 was a bugfix.
Yeah, let's "fix" this and then re-crater it.
We should be able to detect crater fallout by just diffing the changes from 9c3064e and its parent.
@craterbot run mode=check-only start=master#e9182f195b8505c87c4bd055b9f6e114ccda0981 end=master#9c3064e131f4939cc95a29bb11413c49bbda1491
👌 Experiment pr-144098 created and queued.
🔍 You can check out the queue and this experiment's details.
i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
@craterbot
craterbot
added
S-waiting-on-crater
Status: Waiting on a crater run to be completed.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 18, 2025
In the mean time though, let's get this merged.
@bors r+
@bors
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-crater
Status: Waiting on a crater run to be completed.
labels
Jul 18, 2025
#144139 to make sure we don't forget this
bors
added a commit
that referenced
this pull request
Jul 19, 2025
Rollup of 10 pull requests Successful merges: - #141076 (fix Zip unsoundness (again)) - #142444 (adding run-make test to autodiff) - #143704 (Be a bit more careful around exotic cycles in in the inliner) - #144073 (Don't test panic=unwind in panic_main.rs on Fuchsia) - #144083 (miri sleep tests: increase slack) - #144092 (bootstrap: Detect musl hosts) - #144098 (Do not lint private-in-public for RPITIT) - #144103 (Rename `emit_unless` to `emit_unless_delay`) - #144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling) - #144115 (fix outdated comment) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 19, 2025
Rollup merge of #144098 - cjgillot:lint-rpitit, r=compiler-errors Do not lint private-in-public for RPITIT Fixes the hard error introduced by #143357 Instead of trying to accept this hard error directly, this PR copies tests from #144020 and removes the error. If the behaviour is actually desirable, the second commit can be reverted with a proper crater run. cc #143531 for bookkeeping r? `@compiler-errors`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jul 20, 2025
Rollup of 10 pull requests Successful merges: - rust-lang/rust#141076 (fix Zip unsoundness (again)) - rust-lang/rust#142444 (adding run-make test to autodiff) - rust-lang/rust#143704 (Be a bit more careful around exotic cycles in in the inliner) - rust-lang/rust#144073 (Don't test panic=unwind in panic_main.rs on Fuchsia) - rust-lang/rust#144083 (miri sleep tests: increase slack) - rust-lang/rust#144092 (bootstrap: Detect musl hosts) - rust-lang/rust#144098 (Do not lint private-in-public for RPITIT) - rust-lang/rust#144103 (Rename `emit_unless` to `emit_unless_delay`) - rust-lang/rust#144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling) - rust-lang/rust#144115 (fix outdated comment) r? `@ghost` `@rustbot` modify labels: rollup
🚧 Experiment pr-144098 is now running
i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Jul 21, 2025
...rrors Do not lint private-in-public for RPITIT Fixes the hard error introduced by rust-lang#143357 Instead of trying to accept this hard error directly, this PR copies tests from rust-lang#144020 and removes the error. If the behaviour is actually desirable, the second commit can be reverted with a proper crater run. cc rust-lang#143531 for bookkeeping r? `@compiler-errors`
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Jul 21, 2025
...iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#141076 (fix Zip unsoundness (again)) - rust-lang#142444 (adding run-make test to autodiff) - rust-lang#143704 (Be a bit more careful around exotic cycles in in the inliner) - rust-lang#144073 (Don't test panic=unwind in panic_main.rs on Fuchsia) - rust-lang#144083 (miri sleep tests: increase slack) - rust-lang#144092 (bootstrap: Detect musl hosts) - rust-lang#144098 (Do not lint private-in-public for RPITIT) - rust-lang#144103 (Rename `emit_unless` to `emit_unless_delay`) - rust-lang#144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling) - rust-lang#144115 (fix outdated comment) r? `@ghost` `@rustbot` modify labels: rollup
🎉 Experiment pr-144098 is completed!
📊 24 regressed and 3 fixed (667245 total)
📰 Open the summary report.
i️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
@craterbot
craterbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jul 22, 2025
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jul 29, 2025
...iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#141076 (fix Zip unsoundness (again)) - rust-lang#142444 (adding run-make test to autodiff) - rust-lang#143704 (Be a bit more careful around exotic cycles in in the inliner) - rust-lang#144073 (Don't test panic=unwind in panic_main.rs on Fuchsia) - rust-lang#144083 (miri sleep tests: increase slack) - rust-lang#144092 (bootstrap: Detect musl hosts) - rust-lang#144098 (Do not lint private-in-public for RPITIT) - rust-lang#144103 (Rename `emit_unless` to `emit_unless_delay`) - rust-lang#144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling) - rust-lang#144115 (fix outdated comment) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the hard error introduced by #143357
Instead of trying to accept this hard error directly, this PR copies tests from #144020 and removes the error.
If the behaviour is actually desirable, the second commit can be reverted with a proper crater run.
cc #143531 for bookkeeping
r? @compiler-errors