-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Make IoSlice and IoSliceMut methods unstably const
#144090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @ibraheemdev
rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
If this looks good, I'll open a tracking issue and link it.
r? libs-api
@BurntSushi Friendly ping. Would you mind taking a look at this?
This seems fine; if we wind up with an obscure platform for which the vector type can't be constructed at comptime for some reason, we would probably use the unsupported fallback.
Nominated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make a tracking issue for this
This enables constructing
IoSliceandIoSliceMutin const contexts without users needing to break the platform abstraction by doing the cast themselves. This is useful for statics.Since all current and plausible future platforms use simple slice-like structs, this should not impose a burden when adding a new platform with a different struct.